Patch Detail
Show a patch.
GET /api/patches/3639/?format=api
{ "id": 3639, "url": "https://patchwork.libcamera.org/api/patches/3639/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3639/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200430155946.15605-3-email@uajain.com>", "date": "2020-04-30T16:00:02", "name": "[libcamera-devel,v2,2/2] qcam: main_window: Fix combo-box entry selection on startup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8d367914065666a4ec8a2077d1faa025312d5682", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3639/mbox/", "series": [ { "id": 861, "url": "https://patchwork.libcamera.org/api/series/861/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=861", "date": "2020-04-30T16:00:00", "name": "Fix combo-box entry selection on startup", "version": 2, "mbox": "https://patchwork.libcamera.org/series/861/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3639/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3639/checks/", "tags": {}, "headers": { "Return-Path": "<bounces+15657259-5c31-libcamera-devel=lists.libcamera.org@em7280.uajain.com>", "Received": [ "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFFB76142F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 18:00:03 +0200 (CEST)", "by filterdrecv-p3mdw1-6dbfd75bfd-mgvzk with SMTP id\n\tfilterdrecv-p3mdw1-6dbfd75bfd-mgvzk-19-5EAAF602-58\n\t2020-04-30 16:00:02.494997608 +0000 UTC m=+3077565.900999360", "from mail.uajain.com (unknown)\n\tby ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP\n\tid A1N_0a46RCuAs6l4F_j5qA Thu, 30 Apr 2020 16:00:02.187 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"x7icnKYQ\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=to8kvyjFjtpe3sDVdwYz0UBV9lkbEl4iHzD8IrxyY9Y=;\n\tb=x7icnKYQ2MyGjeBMZ8rh1+AjsmytwfZuDikGixVqvPMJk2mr3MGAwGqi82OVCln09zip\n\tYseQuJt7D7qQGQfuA+Ptjj3m7Rh/+9uHZCwa+wLeSnYbCQDiZH8TubMtAEVxyQo6NAVPOD\n\tG9drr3G8uicnOKVai2wkRR3yBDOrdZQAM=", "From": "Umang Jain <email@uajain.com>", "Date": "Thu, 30 Apr 2020 16:00:02 +0000 (UTC)", "Message-Id": "<20200430155946.15605-3-email@uajain.com>", "In-Reply-To": "<20200430155946.15605-1-email@uajain.com>", "References": "<20200430155946.15605-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcREc2X1LpIgLW8oEasGbeg0dNzyr1rvnGXqGeVMcKOlrsDeqL0dRJ9ge7fxuW99NHeUq/ByOGJ9OSpcW09XvGWlyBf/gEhNfe0sPDg5rLxy9HrSiLD2cn0KDbmVlHgvvg7hXAZQwVDig5s1bwHg36vH5Tq6I0fITjJzsGEn5SUnc0pz9YG+GjU/iNxJHXFM8cBputZ7yf8mmLXrUnXHaCCw==", "To": "libcamera-devel <libcamera-devel@lists.libcamera.org>", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=us-ascii", "Subject": "[libcamera-devel] [PATCH v2 2/2] qcam: main_window: Fix combo-box\n\tentry selection on startup", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 30 Apr 2020 16:00:04 -0000" }, "content": "When one of the camera is selected and opened from the\n\"Select Cameras\" items list, the entry of the combo-box\nin the main-window doesn't update its item index to reflect\nthe camera which was earlier selected. Fix that.\n\nSigned-off-by: Umang Jain <email@uajain.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex c95d097..3e92cd9 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -250,6 +250,9 @@ int MainWindow::openCamera()\n \t\treturn -EBUSY;\n \t}\n \n+\t/* Set the combo-box entry with the currently selected Camera */\n+\tcameraCombo_->setCurrentText(QString::fromStdString(cameraName));\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }