Patch Detail
Show a patch.
GET /api/patches/3636/?format=api
{ "id": 3636, "url": "https://patchwork.libcamera.org/api/patches/3636/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3636/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200430141433.6776-3-email@uajain.com>", "date": "2020-04-30T14:15:03", "name": "[libcamera-devel,2/2] qcam: main_window: Fix combo-box entry selection on startup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c28ecec6410840f10e8cbe2c7340c3563c1ff556", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3636/mbox/", "series": [ { "id": 860, "url": "https://patchwork.libcamera.org/api/series/860/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=860", "date": "2020-04-30T14:15:01", "name": "Fix combo-box entry selection on startup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/860/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3636/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3636/checks/", "tags": {}, "headers": { "Return-Path": "<bounces+15657259-5c31-libcamera-devel=lists.libcamera.org@em7280.uajain.com>", "Received": [ "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 684F6613A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:15:04 +0200 (CEST)", "by filterdrecv-p3mdw1-6dbfd75bfd-br5mk with SMTP id\n\tfilterdrecv-p3mdw1-6dbfd75bfd-br5mk-18-5EAADD66-A2\n\t2020-04-30 14:15:03.065126942 +0000 UTC m=+3071266.835650499", "from mail.uajain.com (unknown)\n\tby ismtpd0004p1maa1.sendgrid.net (SG) with ESMTP id\n\tPp9dRUh0QcOxYg-UaGD9Ew for <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 14:15:02.678 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"rysNYrIo\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=FtAbM7tPdRfk8tBnyld8JAFpnNrdycaCsvCkipGAJHs=;\n\tb=rysNYrIoW4uuns1srXTyrJT3K7McFvJ9nwB/v9WT2mo8+P4UJvBe6+PXKELByqznPFGh\n\thIfa5lOkoouIFuAcImWa2fOw9od1jmaDfq4Yi9ZMJV+quQNzPVz9iN+Rz6DfSbwsomkiaV\n\tfcDW+wyDiDhflrvJHV37y6FoLpPzoRoI0=", "From": "Umang Jain <email@uajain.com>", "Date": "Thu, 30 Apr 2020 14:15:03 +0000 (UTC)", "Message-Id": "<20200430141433.6776-3-email@uajain.com>", "In-Reply-To": "<20200430141433.6776-1-email@uajain.com>", "References": "<20200430141433.6776-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcYDswUgqLHty1lirORaEntZ5ZX+Stb2wq2TPNefJ8c+oSaNspsExquBCZZyXPaqOWYS2+egyEWSXCEhUf+TT+PVOhAwasICA/wuzrTsqfv6ZwXC/EBEjpnTAy1BVPLQfB0AG9BxQ+qaNBTg0mmbn1+ckikfO56QWuqbtSfgukWY4OM52SpAdanGYBIQlPVnBnyJ8kvXI7EI6MiyQ+igU3iA==", "To": "libcamera-devel <libcamera-devel@lists.libcamera.org>", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=us-ascii", "Subject": "[libcamera-devel] [PATCH 2/2] qcam: main_window: Fix combo-box\n\tentry selection on startup", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 30 Apr 2020 14:15:04 -0000" }, "content": "When one of the camera is selected and opened from the\n\"Select Cameras\" items list, the entry of the combo-box\nin the main-window doesn't update its item index to reflect\nthe camera which was earlier selected. Fix that.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/qcam/main_window.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 344b7ec..fa05515 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -249,6 +249,10 @@ int MainWindow::openCamera()\n \t\treturn -EBUSY;\n \t}\n \n+\t/* Set the combo-box with the current selected Camera */\n+\tint camIndex = cameraCombo_->findText(QString::fromStdString(cameraName));\n+\tcameraCombo_->setCurrentIndex(camIndex);\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }