Patch Detail
Show a patch.
GET /api/patches/3597/?format=api
{ "id": 3597, "url": "https://patchwork.libcamera.org/api/patches/3597/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3597/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200428181650.5071-2-laurent.pinchart@ideasonboard.com>", "date": "2020-04-28T18:16:49", "name": "[libcamera-devel,v2,2/3] test: camera_sensor: Test the model() function", "commit_ref": "5c8570cf3719260d58a7a8cf44a655dbf9dcb131", "pull_url": null, "state": "accepted", "archived": false, "hash": "70f32a9de69d2c2b9adc60a2b98814135740c57b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3597/mbox/", "series": [ { "id": 845, "url": "https://patchwork.libcamera.org/api/series/845/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=845", "date": "2020-04-28T18:16:48", "name": "[libcamera-devel,v2,1/3] libcamera: camera_sensor: Add model() function", "version": 2, "mbox": "https://patchwork.libcamera.org/series/845/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3597/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3597/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFA3A61AD4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2020 20:16:54 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E1C097D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2020 20:16:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cL3/z9ej\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588097814;\n\tbh=zDqpu+qaIFcdL1zmm4Y6xSUVso4Rjm7wJOkl353Vw40=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=cL3/z9ejXzwsdS5Xc/zBp9XLboMTEdYXM78YCXRkZn3vwWEoHfHp69o1Jyou7NjNR\n\tWtxcDpJAkfop2sVonwl5B08FZj3uHTagozwdC/Nhwuo4oh5OhoM++jL4PULwpMBkHw\n\tqDBwfFk1Jtb+5AiNtzCfX+A69CGhKAwo+q3KXFF0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 28 Apr 2020 21:16:49 +0300", "Message-Id": "<20200428181650.5071-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "In-Reply-To": "<20200428181650.5071-1-laurent.pinchart@ideasonboard.com>", "References": "<20200428181650.5071-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/3] test: camera_sensor: Test the\n\tmodel() function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 28 Apr 2020 18:16:55 -0000" }, "content": "Verify that the sensor model matches the expected value. The whole model\nextraction heuristic isn't fully tested as that would require being able\nto inject different entity names. It is still useful as an initial step.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/camera-sensor.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\nindex 27c190fe7ace..6069d668e495 100644\n--- a/test/camera-sensor.cpp\n+++ b/test/camera-sensor.cpp\n@@ -61,6 +61,12 @@ protected:\n \n \tint run()\n \t{\n+\t\tif (sensor_->model() != \"Sensor A\") {\n+\t\t\tcerr << \"Incorrect sensor model '\" << sensor_->model()\n+\t\t\t << \"'\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\tconst std::vector<unsigned int> &codes = sensor_->mbusCodes();\n \t\tauto iter = std::find(codes.begin(), codes.end(),\n \t\t\t\t MEDIA_BUS_FMT_ARGB8888_1X32);\n", "prefixes": [ "libcamera-devel", "v2", "2/3" ] }