Patch Detail
Show a patch.
GET /api/patches/3453/?format=api
{ "id": 3453, "url": "https://patchwork.libcamera.org/api/patches/3453/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3453/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200413212700.1373247-8-niklas.soderlund@ragnatech.se>", "date": "2020-04-13T21:26:59", "name": "[libcamera-devel,v4,7/8] libcamera: pipeline: vimc: Call IPA start() and stop()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fde05bfd86b3bf9b2298a7d225833bcd6db2a652", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3453/mbox/", "series": [ { "id": 805, "url": "https://patchwork.libcamera.org/api/series/805/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=805", "date": "2020-04-13T21:26:52", "name": "libcamera: ipa_manager: Proxy open-source IPAs to a thread", "version": 4, "mbox": "https://patchwork.libcamera.org/series/805/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3453/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3453/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 482D462E16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 23:27:11 +0200 (CEST)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 8467126f-7dcd-11ea-aeed-005056917f90;\n\tMon, 13 Apr 2020 23:27:03 +0200 (CEST)" ], "X-Halon-ID": "8467126f-7dcd-11ea-aeed-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Apr 2020 23:26:59 +0200", "Message-Id": "<20200413212700.1373247-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200413212700.1373247-1-niklas.soderlund@ragnatech.se>", "References": "<20200413212700.1373247-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 7/8] libcamera: pipeline: vimc: Call\n\tIPA start() and stop()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 13 Apr 2020 21:27:12 -0000" }, "content": "Call the IPA start()/stop() functions before/after the camera is\nstarted. This makes sure the IPA functions properly once thread\nmanagement is moved into the start/stop interface.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex b04a9726efa5ade6..c5eea3a01b0e9446 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -274,8 +274,15 @@ int PipelineHandlerVimc::start(Camera *camera)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tret = data->ipa_->start();\n+\tif (ret) {\n+\t\tdata->video_->releaseBuffers();\n+\t\treturn ret;\n+\t}\n+\n \tret = data->video_->streamOn();\n \tif (ret < 0) {\n+\t\tdata->ipa_->stop();\n \t\tdata->video_->releaseBuffers();\n \t\treturn ret;\n \t}\n@@ -287,6 +294,7 @@ void PipelineHandlerVimc::stop(Camera *camera)\n {\n \tVimcCameraData *data = cameraData(camera);\n \tdata->video_->streamOff();\n+\tdata->ipa_->stop();\n \tdata->video_->releaseBuffers();\n }\n \n", "prefixes": [ "libcamera-devel", "v4", "7/8" ] }