Patch Detail
Show a patch.
GET /api/patches/3452/?format=api
{ "id": 3452, "url": "https://patchwork.libcamera.org/api/patches/3452/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3452/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200413212700.1373247-7-niklas.soderlund@ragnatech.se>", "date": "2020-04-13T21:26:58", "name": "[libcamera-devel,v4,6/8] libcamera: pipeline: rkisp1: Call IPA start() and stop()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "575dcf1bcea9d97efe2dbd9baa1b17fb40b63687", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3452/mbox/", "series": [ { "id": 805, "url": "https://patchwork.libcamera.org/api/series/805/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=805", "date": "2020-04-13T21:26:52", "name": "libcamera: ipa_manager: Proxy open-source IPAs to a thread", "version": 4, "mbox": "https://patchwork.libcamera.org/series/805/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3452/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3452/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C732762826\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 23:27:10 +0200 (CEST)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 841a66d0-7dcd-11ea-aeed-005056917f90;\n\tMon, 13 Apr 2020 23:27:02 +0200 (CEST)" ], "X-Halon-ID": "841a66d0-7dcd-11ea-aeed-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Apr 2020 23:26:58 +0200", "Message-Id": "<20200413212700.1373247-7-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200413212700.1373247-1-niklas.soderlund@ragnatech.se>", "References": "<20200413212700.1373247-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 6/8] libcamera: pipeline: rkisp1: Call\n\tIPA start() and stop()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 13 Apr 2020 21:27:12 -0000" }, "content": "Call the IPA start()/stop() functions before/after the camera is\nstarted. This makes sure the IPA functions properly once thread\nmanagement is moved into the start/stop interface.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex c7068c0c285f3775..e3cdc77ba6be560c 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -780,10 +780,19 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \tif (ret)\n \t\treturn ret;\n \n+\tret = data->ipa_->start();\n+\tif (ret) {\n+\t\tfreeBuffers(camera);\n+\t\tLOG(RkISP1, Error)\n+\t\t\t<< \"Failed to start IPA \" << camera->name();\n+\t\treturn ret;\n+\t}\n+\n \tdata->frame_ = 0;\n \n \tret = param_->streamOn();\n \tif (ret) {\n+\t\tdata->ipa_->stop();\n \t\tfreeBuffers(camera);\n \t\tLOG(RkISP1, Error)\n \t\t\t<< \"Failed to start parameters \" << camera->name();\n@@ -793,6 +802,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \tret = stat_->streamOn();\n \tif (ret) {\n \t\tparam_->streamOff();\n+\t\tdata->ipa_->stop();\n \t\tfreeBuffers(camera);\n \t\tLOG(RkISP1, Error)\n \t\t\t<< \"Failed to start statistics \" << camera->name();\n@@ -803,6 +813,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \tif (ret) {\n \t\tparam_->streamOff();\n \t\tstat_->streamOff();\n+\t\tdata->ipa_->stop();\n \t\tfreeBuffers(camera);\n \n \t\tLOG(RkISP1, Error)\n@@ -846,6 +857,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n \t\tLOG(RkISP1, Warning)\n \t\t\t<< \"Failed to stop parameters \" << camera->name();\n \n+\tdata->ipa_->stop();\n+\n \tdata->timeline_.reset();\n \n \tdata->frameInfo_.clear();\n", "prefixes": [ "libcamera-devel", "v4", "6/8" ] }