Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3438,
    "url": "https://patchwork.libcamera.org/api/patches/3438/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/3438/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200413133047.11913-5-laurent.pinchart@ideasonboard.com>",
    "date": "2020-04-13T13:30:40",
    "name": "[libcamera-devel,v2,04/11] test: Add File class tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "7e4740a3f31565027141e2c4ab360bbefd522216",
    "submitter": {
        "id": 2,
        "url": "https://patchwork.libcamera.org/api/people/2/?format=api",
        "name": "Laurent Pinchart",
        "email": "laurent.pinchart@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/3438/mbox/",
    "series": [
        {
            "id": 804,
            "url": "https://patchwork.libcamera.org/api/series/804/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=804",
            "date": "2020-04-13T13:30:37",
            "name": "Sign IPA modules instead of checking their advertised license",
            "version": 2,
            "mbox": "https://patchwork.libcamera.org/series/804/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/3438/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/3438/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<laurent.pinchart@ideasonboard.com>",
        "Received": [
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0911A6279B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 15:31:06 +0200 (CEST)",
            "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5231A42\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 15:31:05 +0200 (CEST)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"O0EeYu5G\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1586784665;\n\tbh=3vjkyhzAgooy6N+mAEkoE8z1/M7zDgPtGCd5Tgg527E=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=O0EeYu5GZbvO1byfc3GDbQUnqmRZcKfC3mnjOI68oXu59xAgWWCUk/+PSU07MnM1K\n\tY96NMfHezM9P8XXslRrBvyFKImT86Mwi0bRFT42BA3Tb3j2ENVQPjb4ffD0Rv8IqgB\n\tyei49nYUJb0gdX/Z6hddUGOvJE4mVFS0o/WeRHzU=",
        "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Mon, 13 Apr 2020 16:30:40 +0300",
        "Message-Id": "<20200413133047.11913-5-laurent.pinchart@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.24.1",
        "In-Reply-To": "<20200413133047.11913-1-laurent.pinchart@ideasonboard.com>",
        "References": "<20200413133047.11913-1-laurent.pinchart@ideasonboard.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v2 04/11] test: Add File class tests",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Mon, 13 Apr 2020 13:31:06 -0000"
    },
    "content": "Add tests for the File class API.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\nChanges since v1:\n\n- Use mkstemp() to generate temporary file name\n- Add error() test\n---\n test/file.cpp    | 293 +++++++++++++++++++++++++++++++++++++++++++++++\n test/meson.build |   1 +\n 2 files changed, 294 insertions(+)\n create mode 100644 test/file.cpp",
    "diff": "diff --git a/test/file.cpp b/test/file.cpp\nnew file mode 100644\nindex 000000000000..6558399808f8\n--- /dev/null\n+++ b/test/file.cpp\n@@ -0,0 +1,293 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Google Inc.\n+ *\n+ * file.cpp - File I/O operations tests\n+ */\n+\n+#include <fstream>\n+#include <iostream>\n+#include <stdlib.h>\n+#include <string>\n+#include <string.h>\n+#include <sys/types.h>\n+#include <unistd.h>\n+\n+#include \"file.h\"\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class FileTest : public Test\n+{\n+protected:\n+\tint init()\n+\t{\n+\t\tfileName_ = \"/tmp/libcamera.test.XXXXXX\";\n+\t\tint fd = mkstemp(&fileName_.front());\n+\t\tif (fd == -1)\n+\t\t\treturn TestFail;\n+\n+\t\twrite(fd, \"libcamera\", 9);\n+\t\tclose(fd);\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\t/* Test static functions. */\n+\t\tif (!File::exists(\"/dev/null\")) {\n+\t\t\tcerr << \"Valid file not found\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (File::exists(\"/dev/null/invalid\")) {\n+\t\t\tcerr << \"Invalid file should not exist\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test unnamed file. */\n+\t\tFile file;\n+\n+\t\tif (!file.fileName().empty()) {\n+\t\t\tcerr << \"Unnamed file has non-empty file name\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.exists()) {\n+\t\t\tcerr << \"Unnamed file exists\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.isOpen()) {\n+\t\t\tcerr << \"File is open after construction\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.openMode() != File::NotOpen) {\n+\t\t\tcerr << \"File has invalid open mode after construction\"\n+\t\t\t     << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.size() >= 0) {\n+\t\t\tcerr << \"Unnamed file has a size\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.open(File::ReadWrite)) {\n+\t\t\tcerr << \"Opening unnamed file succeeded\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.error() == 0) {\n+\t\t\tcerr << \"Open failure didn't set error\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test named file referring to an invalid file. */\n+\t\tfile.setFileName(\"/dev/null/invalid\");\n+\n+\t\tif (file.fileName() != \"/dev/null/invalid\") {\n+\t\t\tcerr << \"File reports incorrect file name\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.exists()) {\n+\t\t\tcerr << \"Invalid file exists\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.isOpen()) {\n+\t\t\tcerr << \"Invalid file is open after construction\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.openMode() != File::NotOpen) {\n+\t\t\tcerr << \"Invalid file has invalid open mode after construction\"\n+\t\t\t     << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.size() >= 0) {\n+\t\t\tcerr << \"Invalid file has a size\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.open(File::ReadWrite)) {\n+\t\t\tcerr << \"Opening invalid file succeeded\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test named file referring to a valid file. */\n+\t\tfile.setFileName(\"/dev/null\");\n+\n+\t\tif (!file.exists()) {\n+\t\t\tcerr << \"Valid file does not exist\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.isOpen()) {\n+\t\t\tcerr << \"Valid file is open after construction\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.openMode() != File::NotOpen) {\n+\t\t\tcerr << \"Valid file has invalid open mode after construction\"\n+\t\t\t     << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.size() >= 0) {\n+\t\t\tcerr << \"Invalid file has a size\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test open and close. */\n+\t\tif (!file.open(File::ReadWrite)) {\n+\t\t\tcerr << \"Opening file failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!file.isOpen()) {\n+\t\t\tcerr << \"Open file reported as closed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.openMode() != File::ReadWrite) {\n+\t\t\tcerr << \"Open file has invalid open mode\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfile.close();\n+\n+\t\tif (file.isOpen()) {\n+\t\t\tcerr << \"Closed file reported as open\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.openMode() != File::NotOpen) {\n+\t\t\tcerr << \"Closed file has invalid open mode\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test size(). */\n+\t\tfile.setFileName(\"/proc/self/exe\");\n+\n+\t\tif (file.size() >= 0) {\n+\t\t\tcerr << \"File has valid size before open\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfile.open(File::ReadOnly);\n+\n+\t\tssize_t size = file.size();\n+\t\tif (size <= 0) {\n+\t\t\tcerr << \"File has invalid size after open\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test mapping and unmapping. */\n+\t\tSpan<uint8_t> data = file.map();\n+\t\tif (data.empty()) {\n+\t\t\tcerr << \"Mapping of complete file failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (data.size() != static_cast<size_t>(size)) {\n+\t\t\tcerr << \"Mapping  of complete file has invalid size\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!file.unmap(data.data())) {\n+\t\t\tcerr << \"Unmapping of complete file failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tdata = file.map(4096, 8192);\n+\t\tif (data.empty()) {\n+\t\t\tcerr << \"Mapping of file region failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (data.size() != 8192) {\n+\t\t\tcerr << \"Mapping of file region has invalid size\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!file.unmap(data.data())) {\n+\t\t\tcerr << \"Unmapping of file region failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfile.close();\n+\n+\t\t/* Test private mapping. */\n+\t\tfile.setFileName(fileName_);\n+\t\tfile.open(File::ReadWrite);\n+\n+\t\tdata = file.map(0, -1, File::MapPrivate);\n+\t\tif (data.empty()) {\n+\t\t\tcerr << \"Private mapping failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tstd::string str{ reinterpret_cast<char *>(data.data()), data.size() };\n+\t\tif (str != \"libcamera\") {\n+\t\t\tcerr << \"Invalid contents of private mapping\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tmemcpy(data.data(), \"LIBCAMERA\", 9);\n+\n+\t\tif (!file.unmap(data.data())) {\n+\t\t\tcerr << \"Private unmapping failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tdata = file.map();\n+\n+\t\tstr = { reinterpret_cast<char *>(data.data()), data.size() };\n+\t\tif (str != \"libcamera\") {\n+\t\t\tcerr << \"Private mapping changed file contents\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test shared mapping. */\n+\t\tdata = file.map();\n+\t\tif (data.empty()) {\n+\t\t\tcerr << \"Shared mapping failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tmemcpy(data.data(), \"LIBCAMERA\", 9);\n+\n+\t\tif (!file.unmap(data.data())) {\n+\t\t\tcerr << \"Shared unmapping failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tdata = file.map();\n+\n+\t\tstr = { reinterpret_cast<char *>(data.data()), data.size() };\n+\t\tif (str != \"LIBCAMERA\") {\n+\t\t\tcerr << \"Shared mapping failed to change file contents\"\n+\t\t\t     << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup()\n+\t{\n+\t\tunlink(fileName_.c_str());\n+\t}\n+\n+private:\n+\tstd::string fileName_;\n+};\n+\n+TEST_REGISTER(FileTest)\ndiff --git a/test/meson.build b/test/meson.build\nindex 8ab58ac15a2a..5a45a85effd3 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -26,6 +26,7 @@ internal_tests = [\n     ['event',                           'event.cpp'],\n     ['event-dispatcher',                'event-dispatcher.cpp'],\n     ['event-thread',                    'event-thread.cpp'],\n+    ['file',                            'file.cpp'],\n     ['file-descriptor',                 'file-descriptor.cpp'],\n     ['message',                         'message.cpp'],\n     ['object',                          'object.cpp'],\n",
    "prefixes": [
        "libcamera-devel",
        "v2",
        "04/11"
    ]
}