Patch Detail
Show a patch.
GET /api/patches/3404/?format=api
{ "id": 3404, "url": "https://patchwork.libcamera.org/api/patches/3404/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3404/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200404215730.16194-2-andrey.konovalov@linaro.org>", "date": "2020-04-04T21:57:30", "name": "[libcamera-devel,RFC,1/1] libcamera: V4L2VideoDevice::to[V4L2]PixelFormat(): add Bayer formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "610b24fedb754f6fa789f94600d047508666b0d1", "submitter": { "id": 25, "url": "https://patchwork.libcamera.org/api/people/25/?format=api", "name": "Andrey Konovalov", "email": "andrey.konovalov@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3404/mbox/", "series": [ { "id": 799, "url": "https://patchwork.libcamera.org/api/series/799/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=799", "date": "2020-04-04T21:57:29", "name": "libcamera: V4L2VideoDevice::to[V4L2]PixelFormat(): add Bayer formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/799/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3404/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3404/checks/", "tags": {}, "headers": { "Return-Path": "<andrey.konovalov@linaro.org>", "Received": [ "from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0589E629B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Apr 2020 23:57:46 +0200 (CEST)", "by mail-lj1-x22d.google.com with SMTP id 19so10616284ljj.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 04 Apr 2020 14:57:45 -0700 (PDT)", "from localhost.localdomain (37-144-159-139.broadband.corbina.ru.\n\t[37.144.159.139]) by smtp.googlemail.com with ESMTPSA id\n\th16sm7299627ljl.73.2020.04.04.14.57.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 04 Apr 2020 14:57:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"oaApGnRP\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=f4teGIoxrxlepDd6QY3IJoftLa3OQtPOasoCKLGxePk=;\n\tb=oaApGnRPLH9h5+MRkD1UnvUj3NUs7TnJ4lWoDtKUAm3zNaUAooRmg5QdUw/LpyriG2\n\tECaWI5TmdyljKdSomITsFb/fADr3WpNYsK8IlVjY7bYtzHiqs4xWjZZaS4HA59h7Dq//\n\t1LxAk7gfm875eBQVTJMZXGaTAiGEPoDnZTjMH83kbu0hMfdRHfBx3m8WggKMRGIitmx6\n\t1BacuAhpn9aTDvAIlEwr4sPBYnZ3BAuCwl1gYAR8+7lM8xFQFQZHXLDqho/rUeL4bKEj\n\tU25weMsi/pvTYFr67JVW0Qa+yZz1mXW9XHSF8ZxLJK1vpydbWZK8MChL8Md+SUHTG9+I\n\tk8Iw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=f4teGIoxrxlepDd6QY3IJoftLa3OQtPOasoCKLGxePk=;\n\tb=tGgQ9Cqy6uW7oz7urJ+Tg6SDwAM+37EOJCGWE9iX8gMxp50ZORU//gUvk6NrCLo4NU\n\tCTjCjJCJJC+v5o8LaKDTubymZdx6Qja4YNkgA1sG7BQTVS9THzpYd6bLeKri64vXdFDw\n\tHLCcTqmTY461V6EIgAJi+GJHZRE3t+uqc9tpweaqXD/981nRPmKs1EU9W66U38h+iY1o\n\tAS7xUNk/g0+P6ne6eU93pYNL9pM0e3N1tuN4VFCjqMdH8Og7R+7C81WKW4zsd/vRnyz0\n\t/J/WIhzMlhxKi5myUtLccte8jacjkvynBWfucznUpRPIkG3HTfAbZvyXhqCOD+uTmISI\n\tpJJg==", "X-Gm-Message-State": "AGi0PubnmzdUhxRDBW1xzIo+Bw/XSPXQFOh97Z35pcWwQI79EA0sMOpc\n\tmpBparz6AceDMQCYtUuFH+Zdt4J7ydM=", "X-Google-Smtp-Source": "APiQypKae6NjDPtX01rVixQ0kmnSioW71ZupSlbVhYY5Ms0CGvJV1ilciZkevj7MdERsxwaIgrBp2A==", "X-Received": "by 2002:a2e:b896:: with SMTP id r22mr8003783ljp.43.1586037465028;\n\tSat, 04 Apr 2020 14:57:45 -0700 (PDT)", "From": "Andrey Konovalov <andrey.konovalov@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 5 Apr 2020 00:57:30 +0300", "Message-Id": "<20200404215730.16194-2-andrey.konovalov@linaro.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200404215730.16194-1-andrey.konovalov@linaro.org>", "References": "<20200404215730.16194-1-andrey.konovalov@linaro.org>", "Subject": "[libcamera-devel] [RFC 1/1] libcamera:\n\tV4L2VideoDevice::to[V4L2]PixelFormat(): add Bayer formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 04 Apr 2020 21:57:46 -0000" }, "content": "Add support for 8-bit, 10-bit, and 10-bit packed raw Bayer formats in\ntoPixelFormat() and toV4L2PixelFormat() methods of V4L2VideoDevice class.\n\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n---\n src/libcamera/v4l2_videodevice.cpp | 56 ++++++++++++++++++++++++++++++\n 1 file changed, 56 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex eb33a68..2e3aafc 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1687,6 +1687,36 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n \tcase V4L2_PIX_FMT_MJPEG:\n \t\treturn PixelFormat(DRM_FORMAT_MJPEG);\n \n+\t/* 8-bit Bayer formats. */\n+\tcase V4L2_PIX_FMT_SRGGB8:\n+\t\treturn PixelFormat(DRM_FORMAT_SRGGB8);\n+\tcase V4L2_PIX_FMT_SGRBG8:\n+\t\treturn PixelFormat(DRM_FORMAT_SGRBG8);\n+\tcase V4L2_PIX_FMT_SGBRG8:\n+\t\treturn PixelFormat(DRM_FORMAT_SGBRG8);\n+\tcase V4L2_PIX_FMT_SBGGR8:\n+\t\treturn PixelFormat(DRM_FORMAT_SBGGR8);\n+\n+\t/* 10-bit Bayer formats. */\n+\tcase V4L2_PIX_FMT_SRGGB10:\n+\t\treturn PixelFormat(DRM_FORMAT_SRGGB10);\n+\tcase V4L2_PIX_FMT_SGRBG10:\n+\t\treturn PixelFormat(DRM_FORMAT_SGRBG10);\n+\tcase V4L2_PIX_FMT_SGBRG10:\n+\t\treturn PixelFormat(DRM_FORMAT_SGBRG10);\n+\tcase V4L2_PIX_FMT_SBGGR10:\n+\t\treturn PixelFormat(DRM_FORMAT_SBGGR10);\n+\n+\t/* 10-bit Bayer packed formats. */\n+\tcase V4L2_PIX_FMT_SRGGB10P:\n+\t\treturn PixelFormat(DRM_FORMAT_SRGGB10, MIPI_FORMAT_MOD_CSI2_PACKED);\n+\tcase V4L2_PIX_FMT_SGRBG10P:\n+\t\treturn PixelFormat(DRM_FORMAT_SGRBG10, MIPI_FORMAT_MOD_CSI2_PACKED);\n+\tcase V4L2_PIX_FMT_SGBRG10P:\n+\t\treturn PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED);\n+\tcase V4L2_PIX_FMT_SBGGR10P:\n+\t\treturn PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED);\n+\n \t/* V4L2 formats not yet supported by DRM. */\n \tcase V4L2_PIX_FMT_GREY:\n \tdefault:\n@@ -1734,6 +1764,8 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelFormat,\n \t\t\t\t\t\t bool multiplanar)\n {\n+\tbool csi2Packed = pixelFormat.modifier() == MIPI_FORMAT_MOD_CSI2_PACKED;\n+\n \tswitch (pixelFormat) {\n \t/* RGB formats. */\n \tcase DRM_FORMAT_BGR888:\n@@ -1777,6 +1809,30 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n \t/* Compressed formats. */\n \tcase DRM_FORMAT_MJPEG:\n \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_MJPEG);\n+\n+\t/* 8-bit Bayer formats. */\n+\tcase DRM_FORMAT_SRGGB8:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_SRGGB8);\n+\tcase DRM_FORMAT_SGRBG8:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_SGRBG8);\n+\tcase DRM_FORMAT_SGBRG8:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_SGBRG8);\n+\tcase DRM_FORMAT_SBGGR8:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8);\n+\n+\t/* 10-bit Bayer formats, the packed ones included. */\n+\tcase DRM_FORMAT_SRGGB10:\n+\t\treturn (csi2Packed) ? V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10P)\n+\t\t\t: V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10);\n+\tcase DRM_FORMAT_SGRBG10:\n+\t\treturn (csi2Packed) ? V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10P)\n+\t\t\t: V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10);\n+\tcase DRM_FORMAT_SGBRG10:\n+\t\treturn (csi2Packed) ? V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P)\n+\t\t\t: V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10);\n+\tcase DRM_FORMAT_SBGGR10:\n+\t\treturn (csi2Packed) ? V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P)\n+\t\t\t: V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10);\n \t}\n \n \t/*\n", "prefixes": [ "libcamera-devel", "RFC", "1/1" ] }