Patch Detail
Show a patch.
GET /api/patches/3384/?format=api
{ "id": 3384, "url": "https://patchwork.libcamera.org/api/patches/3384/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3384/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200404004438.17992-8-laurent.pinchart@ideasonboard.com>", "date": "2020-04-04T00:44:34", "name": "[libcamera-devel,v4,07/11] libcamera: v4l2_videodevice: Downgrade 4CC conversion errors to warnings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "36b223367d6599069a89952b2fec7a0cd4319114", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3384/mbox/", "series": [ { "id": 796, "url": "https://patchwork.libcamera.org/api/series/796/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=796", "date": "2020-04-04T00:44:27", "name": "Simple pipeline handler", "version": 4, "mbox": "https://patchwork.libcamera.org/series/796/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3384/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3384/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BCBF629B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Apr 2020 02:44:55 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE97414DA;\n\tSat, 4 Apr 2020 02:44:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Kg6tYjyE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585961095;\n\tbh=SLE8NyRGi69ia6Vcrm2HnZBLNbgV81C/Kfg5Chlui80=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Kg6tYjyE/3aisHLNCP96hHHTAnBey8WGIu9tTinBN8oaDp9eo7ltvGwOxItYzyiqL\n\t12ocyqWMRY/niBaC23aIorai0RI78B5u9GLLgM9srYV3MN0JovqcITGYoGdaZGuZSY\n\tydq87hgUmDdsG0Mh0m3eyB+MTCKwrmkWUKkCiJDU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Martijn Braam <martijn@brixit.nl>,\n\tBenjamin GAIGNARD <benjamin.gaignard@st.com>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>", "Date": "Sat, 4 Apr 2020 03:44:34 +0300", "Message-Id": "<20200404004438.17992-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200404004438.17992-1-laurent.pinchart@ideasonboard.com>", "References": "<20200404004438.17992-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 07/11] libcamera: v4l2_videodevice:\n\tDowngrade 4CC conversion errors to warnings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 04 Apr 2020 00:44:55 -0000" }, "content": "Failing to convert between V4L2 and DRM 4CCs indicates something is\nlikely wrong, but doesn't necessarily prevent the camera from being\nusable. It may for instance only limit the number of supported formats.\nDowngrade the related log messages from LogError to LogWarning.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 42b6c1ed1ef8..5208e5a47148 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1711,7 +1711,7 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n \t\t * class. Until we fix the logger, work around it.\n \t\t */\n \t\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n-\t\t\t\tLogError).stream()\n+\t\t\t\tLogWarning).stream()\n \t\t\t<< \"Unsupported V4L2 pixel format \"\n \t\t\t<< v4l2Fourcc.toString();\n \t\treturn PixelFormat();\n@@ -1799,7 +1799,8 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n \t * \\todo We can't use LOG() in a static method of a Loggable\n \t * class. Until we fix the logger, work around it.\n \t */\n-\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(), LogError).stream()\n+\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n+\t\t\tLogWarning).stream()\n \t\t<< \"Unsupported V4L2 pixel format \" << pixelFormat.toString();\n \treturn {};\n }\n", "prefixes": [ "libcamera-devel", "v4", "07/11" ] }