Patch Detail
Show a patch.
GET /api/patches/3358/?format=api
{ "id": 3358, "url": "https://patchwork.libcamera.org/api/patches/3358/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3358/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200327193424.13221-1-laurent.pinchart@ideasonboard.com>", "date": "2020-03-27T19:34:24", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Fix compilation on gcc 5 and 6", "commit_ref": "8f8992e4ee181f1efba3b8ab5eb680e425bf1b12", "pull_url": null, "state": "accepted", "archived": false, "hash": "91e4a916683de53ea9a5383df23446bffe01395c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3358/mbox/", "series": [ { "id": 788, "url": "https://patchwork.libcamera.org/api/series/788/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=788", "date": "2020-03-27T19:34:24", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Fix compilation on gcc 5 and 6", "version": 1, "mbox": "https://patchwork.libcamera.org/series/788/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3358/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3358/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA02D6040E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Mar 2020 20:34:31 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6214D2DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Mar 2020 20:34:31 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oy0JxLnV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585337671;\n\tbh=gqlHX4f4jN3DTsXairSGdky7P+yMX5cQtZSHWy6IaVs=;\n\th=From:To:Subject:Date:From;\n\tb=oy0JxLnVGKW5l/o9T2JeMVL9YpKg3i02OVvvuBoNlVzJpgp0i2gH5RIVv+Fk/YjyD\n\tQCdF+9ieCJxQyH3TiZomVar7LBB4OKFFiIQqx+90stsEpXxZlWNQhkiDFdK/Opyw/V\n\tQ4D5tdT6NKigtaR2CaJ/Skwqv8EnXv/lH7jvrLN8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Mar 2020 21:34:24 +0200", "Message-Id": "<20200327193424.13221-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tcompilation on gcc 5 and 6", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 27 Mar 2020 19:34:32 -0000" }, "content": "Commit 5e7c5d64a67f (\"libcamera: ipu3: Do not unconditionally queue\nbuffers to CIO2\") introduced usage of the std::queue default constructor\nby using copy-list-initialization from {}. The default constructor was\nexplicit in C++11, which was fixed retroactively with a defect report\n(http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0935r0.html).\ngcc 5 and 6 are unfortunately affected, requiring explicit usage of the\nconstructor.\n\nFixes: 5e7c5d64a67f (\"libcamera: ipu3: Do not unconditionally queue buffers to CIO2\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex b490a801a9c4..1e114ca7ed10 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1532,7 +1532,8 @@ int CIO2Device::allocateBuffers()\n \n void CIO2Device::freeBuffers()\n {\n-\tavailableBuffers_ = {};\n+\t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n+\tavailableBuffers_ = std::queue<FrameBuffer *>{};\n \n \tbuffers_.clear();\n \n", "prefixes": [ "libcamera-devel" ] }