Patch Detail
Show a patch.
GET /api/patches/3317/?format=api
{ "id": 3317, "url": "https://patchwork.libcamera.org/api/patches/3317/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3317/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200325085805.11749-2-laurent.pinchart@ideasonboard.com>", "date": "2020-03-25T08:58:03", "name": "[libcamera-devel,1/3] libcamera: pipeline: Move uvcvideo and vimc to subdirectories", "commit_ref": "5e8933eeebcedda55d4c4e84db9b4983eecefe1b", "pull_url": null, "state": "accepted", "archived": false, "hash": "802b10a344ac9ae0d766f5536900e4800c3a6f44", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3317/mbox/", "series": [ { "id": 773, "url": "https://patchwork.libcamera.org/api/series/773/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=773", "date": "2020-03-25T08:58:02", "name": "Make pipeline handlers selectable at compile time", "version": 1, "mbox": "https://patchwork.libcamera.org/series/773/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3317/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3317/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE34C62BD6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2020 09:58:10 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86B349D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2020 09:58:10 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fh6lTPGV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585126690;\n\tbh=hjyeAdvFPjYAKCoSVE/6XfFh9s797ggPcA4DXIEnvVo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fh6lTPGVUYqyLM6FJjGEGL9tTjArnzwW11YMJu6GXI30i8qfFOTX9n01rDc2fhCPl\n\tBpf5AKs9CKBcWVKi3xqWFgV2S7xhosixI5dfvd9HRlHZzq5eylo4Krj6HIzI5CULt3\n\tDfiKgyzUdfwyJZy9Eik9SAvvUUz9HxGpAPR1U6wo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 25 Mar 2020 10:58:03 +0200", "Message-Id": "<20200325085805.11749-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200325085805.11749-1-laurent.pinchart@ideasonboard.com>", "References": "<20200325085805.11749-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: pipeline: Move uvcvideo\n\tand vimc to subdirectories", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 25 Mar 2020 08:58:11 -0000" }, "content": "Give a subdirectory to all pipeline handlers to make the structure of\nthe source tree more consistent. This will also simplify the\nimplementation of pipeline handlers selection at build time.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/meson.build | 7 ++-----\n src/libcamera/pipeline/uvcvideo/meson.build | 3 +++\n src/libcamera/pipeline/{ => uvcvideo}/uvcvideo.cpp | 0\n src/libcamera/pipeline/vimc/meson.build | 3 +++\n src/libcamera/pipeline/{ => vimc}/vimc.cpp | 0\n 5 files changed, 8 insertions(+), 5 deletions(-)\n create mode 100644 src/libcamera/pipeline/uvcvideo/meson.build\n rename src/libcamera/pipeline/{ => uvcvideo}/uvcvideo.cpp (100%)\n create mode 100644 src/libcamera/pipeline/vimc/meson.build\n rename src/libcamera/pipeline/{ => vimc}/vimc.cpp (100%)", "diff": "diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\nindex 0d466225a72e..c1a6ab0484f0 100644\n--- a/src/libcamera/pipeline/meson.build\n+++ b/src/libcamera/pipeline/meson.build\n@@ -1,7 +1,4 @@\n-libcamera_sources += files([\n- 'uvcvideo.cpp',\n- 'vimc.cpp',\n-])\n-\n subdir('ipu3')\n subdir('rkisp1')\n+subdir('uvcvideo')\n+subdir('vimc')\ndiff --git a/src/libcamera/pipeline/uvcvideo/meson.build b/src/libcamera/pipeline/uvcvideo/meson.build\nnew file mode 100644\nindex 000000000000..c19ae2389f48\n--- /dev/null\n+++ b/src/libcamera/pipeline/uvcvideo/meson.build\n@@ -0,0 +1,3 @@\n+libcamera_sources += files([\n+ 'uvcvideo.cpp',\n+])\ndiff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nsimilarity index 100%\nrename from src/libcamera/pipeline/uvcvideo.cpp\nrename to src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\ndiff --git a/src/libcamera/pipeline/vimc/meson.build b/src/libcamera/pipeline/vimc/meson.build\nnew file mode 100644\nindex 000000000000..615ecd20f1a2\n--- /dev/null\n+++ b/src/libcamera/pipeline/vimc/meson.build\n@@ -0,0 +1,3 @@\n+libcamera_sources += files([\n+ 'vimc.cpp',\n+])\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nsimilarity index 100%\nrename from src/libcamera/pipeline/vimc.cpp\nrename to src/libcamera/pipeline/vimc/vimc.cpp\n", "prefixes": [ "libcamera-devel", "1/3" ] }