Patch Detail
Show a patch.
GET /api/patches/3310/?format=api
{ "id": 3310, "url": "https://patchwork.libcamera.org/api/patches/3310/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3310/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200324175643.22382-4-kgupta@es.iitr.ac.in>", "date": "2020-03-24T17:56:43", "name": "[libcamera-devel,v2,3/3] libcamera: pipeline: ipu3: Use parameterized StreamConfiguration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cc1e68d3e2a1a2a55bf68bc93eabc0899ef87c4e", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/3310/mbox/", "series": [ { "id": 771, "url": "https://patchwork.libcamera.org/api/series/771/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=771", "date": "2020-03-24T17:56:40", "name": "Use StreamFormats in pipelines", "version": 2, "mbox": "https://patchwork.libcamera.org/series/771/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3310/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3310/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com\n\t[IPv6:2607:f8b0:4864:20::1044])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D0CB62BEB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 18:57:14 +0100 (CET)", "by mail-pj1-x1044.google.com with SMTP id v13so1929006pjb.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 10:57:14 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tb17sm16774962pff.81.2020.03.24.10.57.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Mar 2020 10:57:12 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=es-iitr-ac-in.20150623.gappssmtp.com\n\theader.i=@es-iitr-ac-in.20150623.gappssmtp.com header.b=\"L9HAGOc8\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=dNTjpE4aJ2HhzaxdksRpZD9ZJFccgdF6ws3erMNs82o=;\n\tb=L9HAGOc8G9BBb32pnUqHNA9xqWr/WwGtKZjupUEOQDQShY79zb9P3RDeFdnhrXWJ97\n\tNCL3KBFLuHHqyyNnQsNSifgwb38LLrjSxvl8FSPHNrOzBmJZwZLvCzXXwEuAAZaD3Ad6\n\tJsCyMIh6iD0uplH19S9HfR5E4awliusumX6AULk5O/0ueF/tys9kBxgQt60y7NIqNsGE\n\t7aCM0m5NOZK3hZeObp4XEIBF7CKKMfeJBdQoFfSIXL+cqZs2Zo3OxBqjVzCJwVIKUtog\n\t7x9i6gN+zDdyuqBxMLP1jHYwldhyOund1jRrKWKO0Mm0tYtgeojb0ZcrBVFqxXJtRntN\n\tavpQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=dNTjpE4aJ2HhzaxdksRpZD9ZJFccgdF6ws3erMNs82o=;\n\tb=EUtPjqOGTLkdwoi7Tbv4KPmAUwbtdnNkNaM+GI+CUhLQkAxqZFAP+vdYmOB0G5+b/+\n\tJxJKCIFwLPBP9zsYTE9NS5/lNnFIEYbHbBpv+LgGbzJiY8MZrVg9TJ737kib0guKUDO6\n\tASmuPDP4qJRFZgJR1rp+jCLvlZPayjzqwmzcCK0MT1rmWeRHWUQN5PucTogRjsoJnbS/\n\teBWICe6O1yFwYSBzpCkF+zJvILOxEsuUQ1jX07lxLygI/73bgW9gE0ZGL7OcR9ufWEij\n\tcghx4D+3hmamVXHj2biBWJIZHKpP/lpI6Vz9O/eLI4o3yV1gjQcldPzs8Sa5BJT5r/Zz\n\tsQyA==", "X-Gm-Message-State": "ANhLgQ13OhVxKyUQgKZsfyXs8/Fs1GLNkfe9uB9NS5a2M0Ihtoz+1sDw\n\tCj/pbecgg3lrrPbWrtfUYZZBIQ==", "X-Google-Smtp-Source": "ADFU+vvEz+Lq6Si4B7AhWju30c+CYcDGtoq57FTZuGO98E2u/XBBKpuAJP0IKpnBlC1PbdaMHN0K0A==", "X-Received": "by 2002:a17:902:bb92:: with SMTP id\n\tm18mr28265022pls.46.1585072632929; \n\tTue, 24 Mar 2020 10:57:12 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tHelen Koike <helen.koike@collabora.com>,\n\tVaishali Thakkar <vthakkar@vaishalithakkar.in>", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "Date": "Tue, 24 Mar 2020 23:26:43 +0530", "Message-Id": "<20200324175643.22382-4-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200324175643.22382-1-kgupta@es.iitr.ac.in>", "References": "<20200324175643.22382-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: ipu3: Use\n\tparameterized StreamConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 24 Mar 2020 17:57:14 -0000" }, "content": "Replace default constructor StreamConfiguration() by its parameterized\ncounterpart by using StreamFormats in generateConfiguration() in\nipu3\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 36f3990..1400099 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -399,9 +399,18 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \t};\n \n \tconfig = new IPU3CameraConfiguration(camera, data);\n+\tImgUDevice *imgu = data->imgu_;\n+\tV4L2VideoDevice *dev = (imgu->output_).dev;\n+\tauto formats = (*dev).formats();\n+\n+\t/* We find the range of the only pixel format that the driver upports. */\n+\tstd::vector<SizeRange> range = formats[V4L2PixelFormat(PixelFormat(DRM_FORMAT_NV12))];\n+\tstd::map<PixelFormat, std::vector<SizeRange>> pixelformats;\n+\tpixelformats[PixelFormat(DRM_FORMAT_NV12)] = {range};\n \n \tfor (const StreamRole role : roles) {\n-\t\tStreamConfiguration cfg = {};\n+\t\tStreamFormats format(pixelformats);\n+\t\tStreamConfiguration cfg(format);\n \t\tIPU3Stream *stream = nullptr;\n \n \t\tcfg.pixelFormat = PixelFormat(DRM_FORMAT_NV12);\n", "prefixes": [ "libcamera-devel", "v2", "3/3" ] }