Patch Detail
Show a patch.
GET /api/patches/3283/?format=api
{ "id": 3283, "url": "https://patchwork.libcamera.org/api/patches/3283/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3283/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323173559.21109-18-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T17:35:55", "name": "[libcamera-devel,v2,17/21] qcam: viewfinder: Use PixelFormat default constructor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "43b2f868515b6d561bcae94e4db981b9b0d81e2d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3283/mbox/", "series": [ { "id": 762, "url": "https://patchwork.libcamera.org/api/series/762/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=762", "date": "2020-03-23T17:35:38", "name": "qcam: Bypass format conversion when not required", "version": 2, "mbox": "https://patchwork.libcamera.org/series/762/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3283/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3283/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3865362CBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:22 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6E71308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:21 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984981;\n\tbh=KHky5wQDrxlrZylZbKpfKU6yMx+vbRwM5uH5RwoXuEU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=d/uR5jN7GRT888MSILxik8RfJIPXfl+KldV/XphcdTJKQWReG7P1X9x7rH4ufS6Ih\n\t8Y2pxqFjLQmeJVoaLJ7hu3yVKIa8HhmlgXc7cYPgfY73XOp+H4bdU+Y9+irYIE8uaZ\n\tQ9+0aNpls1TxcYrrd8Rk4Ow5vYjgjYPMCJ60Kts0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 19:35:55 +0200", "Message-Id": "<20200323173559.21109-18-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 17/21] qcam: viewfinder: Use\n\tPixelFormat default constructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 17:36:26 -0000" }, "content": "There's no need to initialize the PixelFormat stored in ViewFinder\nexplicitly, as PixelFormat is now a class with a default constructor.\nRemove the initialization.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/viewfinder.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex e7b12015d8f6..c4471ffa4a06 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -16,7 +16,7 @@\n #include \"format_converter.h\"\n \n ViewFinder::ViewFinder(QWidget *parent)\n-\t: QWidget(parent), format_(0)\n+\t: QWidget(parent)\n {\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "17/21" ] }