Patch Detail
Show a patch.
GET /api/patches/3276/?format=api
{ "id": 3276, "url": "https://patchwork.libcamera.org/api/patches/3276/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3276/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323173559.21109-12-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T17:35:49", "name": "[libcamera-devel,v2,11/21] qcam: main_window: Remove unneeded debug message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b65530d4e5b73a122dbbe84fe6174f1b5ae640c2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3276/mbox/", "series": [ { "id": 762, "url": "https://patchwork.libcamera.org/api/series/762/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=762", "date": "2020-03-23T17:35:38", "name": "qcam: Bypass format conversion when not required", "version": 2, "mbox": "https://patchwork.libcamera.org/series/762/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3276/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3276/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F8B562C54\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:20 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBA98A31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:19 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984979;\n\tbh=0XGZiIToAwEhSgXz1L2qCDg0+oPVA50ixpHiATOmZtE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=glu+LCGo2QoEi7Ihlhe0a5xQiPmdF9KRflmAXHDvEjP8PhAzzvRAn5Ll2CF2/Oqxb\n\tkT3tKPStaNSCYiLCyjQN0fSfukgFxDpJIGK1F9azM0KPRb67mwDVa8JTzVJZxEkUjY\n\tMvCByzh1JLb+ZgB0Df/dxP9vmEmOSLmrZhEFCGt4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 19:35:49 +0200", "Message-Id": "<20200323173559.21109-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 11/21] qcam: main_window: Remove\n\tunneeded debug message", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 17:36:23 -0000" }, "content": "Printing the name of the selected camera to the log doesn't provide any\nvalue. Remove it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 20e84171e4a5..c0d42c64749c 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -249,8 +249,6 @@ int MainWindow::openCamera()\n \t\treturn -EBUSY;\n \t}\n \n-\tstd::cout << \"Using camera \" << camera_->name() << std::endl;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "11/21" ] }