Patch Detail
Show a patch.
GET /api/patches/3274/?format=api
{ "id": 3274, "url": "https://patchwork.libcamera.org/api/patches/3274/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3274/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323173559.21109-9-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T17:35:46", "name": "[libcamera-devel,v2,08/21] qcam: main_window: Add shortcuts for toolbar actions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "70b6e964fc908c448127ce62536d3a7552e78052", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3274/mbox/", "series": [ { "id": 762, "url": "https://patchwork.libcamera.org/api/series/762/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=762", "date": "2020-03-23T17:35:38", "name": "qcam: Bypass format conversion when not required", "version": 2, "mbox": "https://patchwork.libcamera.org/series/762/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3274/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3274/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2859662C9A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:19 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD199308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:18 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984978;\n\tbh=Xracp1fiNf22uYy2CLIxNfwSgQxuNQd7bvIJzTbxX38=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=lx51jEm3x2b06XzP44GINNRt47UGAEXJym+RZwnV+AYGO70vQA8pkuz+085b2i3wi\n\tF4GM6rXG6VyVh/NX1U3QPNxa4PdOoECkVR5hAoCWlZmyaak0iv3j2T7582G/tNESvi\n\ti5D0ms6ZQrAJ4lRRAy33BO5lB5JMdcKtcyzJE1tE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 19:35:46 +0200", "Message-Id": "<20200323173559.21109-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 08/21] qcam: main_window: Add shortcuts\n\tfor toolbar actions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 17:36:22 -0000" }, "content": "Allow triggering toolbar actions with keyboard shortcuts.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nChanges since v1:\n\n- Use QKeySequence::SaveAs\n---\n src/qcam/main_window.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 9f008a57f9a1..6afb7714c457 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -99,6 +99,7 @@ int MainWindow::createToolbars()\n \taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n \t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n \t\t\t\t \"Quit\");\n+\taction->setShortcut(Qt::CTRL | Qt::Key_Q);\n \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n \n \t/* Camera selection. */\n@@ -120,12 +121,14 @@ int MainWindow::createToolbars()\n \n \taction = toolbar_->addAction(iconPlay_, \"Start Capture\");\n \taction->setCheckable(true);\n+\taction->setShortcut(Qt::Key_Space);\n \tconnect(action, &QAction::toggled, this, &MainWindow::toggleCapture);\n \tstartStopAction_ = action;\n \n \taction = toolbar_->addAction(QIcon::fromTheme(\"document-save-as\",\n \t\t\t\t\t\t QIcon(\":save.svg\")),\n \t\t\t\t \"Save As...\");\n+\taction->setShortcut(QKeySequence::SaveAs);\n \tconnect(action, &QAction::triggered, this, &MainWindow::saveImageAs);\n \n \treturn 0;\n", "prefixes": [ "libcamera-devel", "v2", "08/21" ] }