Patch Detail
Show a patch.
GET /api/patches/3245/?format=api
{ "id": 3245, "url": "https://patchwork.libcamera.org/api/patches/3245/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3245/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323142205.28342-3-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T14:21:46", "name": "[libcamera-devel,02/21] qcam: Ensure headers are self-contained", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a976668d33fc293f2028ede63dcece248bb8bf75", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3245/mbox/", "series": [ { "id": 760, "url": "https://patchwork.libcamera.org/api/series/760/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=760", "date": "2020-03-23T14:21:44", "name": "qcam: Bypass format conversion when not required", "version": 1, "mbox": "https://patchwork.libcamera.org/series/760/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3245/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3245/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ABE16041A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:19 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A82AC308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:18 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584973338;\n\tbh=4XLUshCMNIt87XB720GbiwJWGezmI9nsCi4TKE0C6kU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=CErJPVeoZzWA1TMEux6MpAnpnVD53E9OtbSYZmTSrcIUfYzog74xOVQiMsexUFQ1w\n\tK9AOm0Id/bSqKNWAsvCkN3xETyiOxL3pMY9p8SwGenPqrHHXCP3O0x1NFvfLpF75Sz\n\tj8Gzxq9jpSQToxj8olJXoVt8gFswR92xcd50MNyA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 16:21:46 +0200", "Message-Id": "<20200323142205.28342-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 02/21] qcam: Ensure headers are\n\tself-contained", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 14:22:19 -0000" }, "content": "Include the headers corresponding to each compile unit at the very first\nline to ensure they are self-contained.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/format_converter.cpp | 4 ++--\n src/qcam/main_window.cpp | 3 ++-\n src/qcam/viewfinder.cpp | 3 ++-\n 3 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\nindex 483f7c1edfce..d8962a28c06c 100644\n--- a/src/qcam/format_converter.cpp\n+++ b/src/qcam/format_converter.cpp\n@@ -5,12 +5,12 @@\n * format_convert.cpp - qcam - Convert buffer to RGB\n */\n \n+#include \"format_converter.h\"\n+\n #include <errno.h>\n \n #include <QImage>\n \n-#include \"format_converter.h\"\n-\n #define RGBSHIFT\t\t8\n #ifndef MAX\n #define MAX(a,b)\t\t((a)>(b)?(a):(b))\ndiff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 6f4f1cd770bd..66aaf40c5d45 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -5,6 +5,8 @@\n * main_window.cpp - qcam - Main application window\n */\n \n+#include \"main_window.h\"\n+\n #include <iomanip>\n #include <iostream>\n #include <string>\n@@ -25,7 +27,6 @@\n #include <libcamera/camera_manager.h>\n #include <libcamera/version.h>\n \n-#include \"main_window.h\"\n #include \"viewfinder.h\"\n \n using namespace libcamera;\ndiff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex e9d5cc1e014b..f4602f07c5d2 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -5,13 +5,14 @@\n * viewfinder.cpp - qcam - Viewfinder\n */\n \n+#include \"viewfinder.h\"\n+\n #include <QImage>\n #include <QImageWriter>\n #include <QMutexLocker>\n #include <QPainter>\n \n #include \"format_converter.h\"\n-#include \"viewfinder.h\"\n \n ViewFinder::ViewFinder(QWidget *parent)\n \t: QWidget(parent), format_(0), width_(0), height_(0), image_(nullptr)\n", "prefixes": [ "libcamera-devel", "02/21" ] }