Patch Detail
Show a patch.
GET /api/patches/3212/?format=api
{ "id": 3212, "url": "https://patchwork.libcamera.org/api/patches/3212/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3212/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200320014839.14683-5-laurent.pinchart@ideasonboard.com>", "date": "2020-03-20T01:48:32", "name": "[libcamera-devel,v3,04/11] libcamera: v4l2_subdevice: Don't use doxygen \\ref needlessly", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "504cc1f9d601cb8f4e5ae6eba4ddd6b6633933a1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3212/mbox/", "series": [ { "id": 749, "url": "https://patchwork.libcamera.org/api/series/749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=749", "date": "2020-03-20T01:48:28", "name": "Simple pipeline handler", "version": 3, "mbox": "https://patchwork.libcamera.org/series/749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3212/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3212/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DCEC62B90\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Mar 2020 02:48:53 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A58913C2;\n\tFri, 20 Mar 2020 02:48:52 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584668933;\n\tbh=n6kBxFpep6vevtnx3jm8XuuWOteokWZ6wvu3GXl/GzI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=O2Bk2qX80a9n4fA1WSFojP9k4SBhQdvoeE+81ccyOlnTN8vwtw7pHICytTylPtx1Q\n\tRyX9fhNKAsmnrBOrbcsEpzbZSU5yDowXEowIFg03So5/xWeSSxnbBHsg5hSjRna9Rt\n\tlnw3fWRz8Fq65yUOyosMl0ycWacGHBPTDzHFhGXo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Martijn Braam <martijn@brixit.nl>,\n\tBenjamin GAIGNARD <benjamin.gaignard@st.com>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>", "Date": "Fri, 20 Mar 2020 03:48:32 +0200", "Message-Id": "<20200320014839.14683-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>", "References": "<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/11] libcamera: v4l2_subdevice: Don't\n\tuse doxygen \\ref needlessly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 20 Mar 2020 01:48:54 -0000" }, "content": "The doxygen \\ref command is used to generate a reference to a function,\nwhile adding parentheses after the function name is enough. Simplify the\ndocumentation.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/v4l2_subdevice.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex f554d2385fff..c28e591ba51a 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -228,8 +228,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n * \"ActiveFormat\" or \\ref V4L2Subdevice::TryFormat \"TryFormat\"\n *\n * Apply the requested image format to the desired media pad and return the\n- * actually applied format parameters, as \\ref V4L2Subdevice::getFormat would\n- * do.\n+ * actually applied format parameters, as getFormat() would do.\n *\n * \\return 0 on success or a negative error code otherwise\n */\n", "prefixes": [ "libcamera-devel", "v3", "04/11" ] }