Patch Detail
Show a patch.
GET /api/patches/3156/?format=api
{ "id": 3156, "url": "https://patchwork.libcamera.org/api/patches/3156/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3156/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200318033200.3042855-4-niklas.soderlund@ragnatech.se>", "date": "2020-03-18T03:31:55", "name": "[libcamera-devel,v3,3/8] test: v4l2_videodevice: buffer_cache: Use DRM pixel format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bf6330200c815358962efcafa2c16805e692aaaa", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3156/mbox/", "series": [ { "id": 730, "url": "https://patchwork.libcamera.org/api/series/730/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=730", "date": "2020-03-18T03:31:52", "name": "libcamera: PixelFormat: Turn into a class", "version": 3, "mbox": "https://patchwork.libcamera.org/series/730/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3156/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3156/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74D7D6297B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Mar 2020 04:32:37 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 1c93e98d-68c9-11ea-9f85-005056917a89;\n\tWed, 18 Mar 2020 04:32:36 +0100 (CET)" ], "X-Halon-ID": "1c93e98d-68c9-11ea-9f85-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 18 Mar 2020 04:31:55 +0100", "Message-Id": "<20200318033200.3042855-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>", "References": "<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 3/8] test: v4l2_videodevice:\n\tbuffer_cache: Use DRM pixel format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 18 Mar 2020 03:32:37 -0000" }, "content": "The pixel format used in the stream configuration is from V4L2 but\nshould be from DRM, fix it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/buffer_cache.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\nindex 0a8cb0d28ca9b204..e6edd2fad7aa3d33 100644\n--- a/test/v4l2_videodevice/buffer_cache.cpp\n+++ b/test/v4l2_videodevice/buffer_cache.cpp\n@@ -142,7 +142,7 @@ public:\n \t\tconst unsigned int numBuffers = 8;\n \n \t\tStreamConfiguration cfg;\n-\t\tcfg.pixelFormat = V4L2_PIX_FMT_YUYV;\n+\t\tcfg.pixelFormat = DRM_FORMAT_YUYV;\n \t\tcfg.size = Size(600, 800);\n \t\tcfg.bufferCount = numBuffers;\n \n", "prefixes": [ "libcamera-devel", "v3", "3/8" ] }