Patch Detail
Show a patch.
GET /api/patches/3155/?format=api
{ "id": 3155, "url": "https://patchwork.libcamera.org/api/patches/3155/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3155/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200318033200.3042855-3-niklas.soderlund@ragnatech.se>", "date": "2020-03-18T03:31:54", "name": "[libcamera-devel,v3,2/8] libcamera: pixelformats: include linux/drm_fourcc.h", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "55d9173f82714baaafe0ed0ff93a227c6a75ccac", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3155/mbox/", "series": [ { "id": 730, "url": "https://patchwork.libcamera.org/api/series/730/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=730", "date": "2020-03-18T03:31:52", "name": "libcamera: PixelFormat: Turn into a class", "version": 3, "mbox": "https://patchwork.libcamera.org/series/730/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3155/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3155/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6C3E6041A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Mar 2020 04:32:36 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 1c3f677a-68c9-11ea-9f85-005056917a89;\n\tWed, 18 Mar 2020 04:32:36 +0100 (CET)" ], "X-Halon-ID": "1c3f677a-68c9-11ea-9f85-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 18 Mar 2020 04:31:54 +0100", "Message-Id": "<20200318033200.3042855-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>", "References": "<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/8] libcamera: pixelformats: include\n\tlinux/drm_fourcc.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 18 Mar 2020 03:32:37 -0000" }, "content": "Instead of having to include linux/drm_fourcc.h everywhere a DRM FourCC\nare used in conjunction with PixelFormat include the header directly in\npixelformats.h.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/pixelformats.h | 2 ++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n src/libcamera/pipeline/vimc.cpp | 1 -\n src/libcamera/v4l2_videodevice.cpp | 1 -\n src/qcam/format_converter.cpp | 2 --\n src/v4l2/v4l2_camera_proxy.cpp | 1 -\n 7 files changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/libcamera/pixelformats.h b/include/libcamera/pixelformats.h\nindex 6e25b8d8b76e5961..544363af7a8c6f05 100644\n--- a/include/libcamera/pixelformats.h\n+++ b/include/libcamera/pixelformats.h\n@@ -9,6 +9,8 @@\n \n #include <stdint.h>\n \n+#include <linux/drm_fourcc.h>\n+\n namespace libcamera {\n \n using PixelFormat = uint32_t;\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 0c2a217c9ea8f6ba..1e3d8a107c6475be 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -10,7 +10,6 @@\n #include <memory>\n #include <vector>\n \n-#include <linux/drm_fourcc.h>\n #include <linux/media-bus-format.h>\n \n #include <libcamera/camera.h>\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex dec0ad6118241ff1..a95ae48ac8cfbc98 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -11,7 +11,6 @@\n #include <memory>\n #include <queue>\n \n-#include <linux/drm_fourcc.h>\n #include <linux/media-bus-format.h>\n \n #include <ipa/rkisp1.h>\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex a30e416e6000bcda..de2458afff3a4784 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -10,7 +10,6 @@\n #include <iomanip>\n #include <tuple>\n \n-#include <linux/drm_fourcc.h>\n #include <linux/media-bus-format.h>\n \n #include <ipa/ipa_interface.h>\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 858310c3b810350a..3869766046236f34 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -18,7 +18,6 @@\n #include <unistd.h>\n #include <vector>\n \n-#include <linux/drm_fourcc.h>\n #include <linux/version.h>\n \n #include <libcamera/event_notifier.h>\ndiff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\nindex d4a66f381f5a1b78..7b8ad77c42fe85d4 100644\n--- a/src/qcam/format_converter.cpp\n+++ b/src/qcam/format_converter.cpp\n@@ -7,8 +7,6 @@\n \n #include <errno.h>\n \n-#include <linux/drm_fourcc.h>\n-\n #include <QImage>\n \n #include \"format_converter.h\"\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex b620f236499cf77d..e349fbddc2a4d5a2 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -10,7 +10,6 @@\n #include <algorithm>\n #include <array>\n #include <errno.h>\n-#include <linux/drm_fourcc.h>\n #include <linux/videodev2.h>\n #include <string.h>\n #include <sys/mman.h>\n", "prefixes": [ "libcamera-devel", "v3", "2/8" ] }