Patch Detail
Show a patch.
GET /api/patches/3148/?format=api
{ "id": 3148, "url": "https://patchwork.libcamera.org/api/patches/3148/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3148/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200318001009.32512-3-kgupta@es.iitr.ac.in>", "date": "2020-03-18T00:10:05", "name": "[libcamera-devel,v2,2/6] libcamera: ipa_proxy: rearrange proxies precedence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ef3f55405ad05c244b558abdebdea1001d2c2171", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3148/mbox/", "series": [ { "id": 729, "url": "https://patchwork.libcamera.org/api/series/729/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=729", "date": "2020-03-18T00:10:03", "name": "libcamera: determine IPA_PROXY_PATH at runtime", "version": 2, "mbox": "https://patchwork.libcamera.org/series/729/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3148/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3148/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com\n\t[IPv6:2607:f8b0:4864:20::1043])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B5CC60422\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Mar 2020 01:10:36 +0100 (CET)", "by mail-pj1-x1043.google.com with SMTP id ck23so454892pjb.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Mar 2020 17:10:36 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.153])\n\tby smtp.gmail.com with ESMTPSA id\n\tw11sm4102523pfn.4.2020.03.17.17.10.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Mar 2020 17:10:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=rdfoQjGn5hqOOYCxvBAN9ITJhTDA0Hwl1+8XEz2sZtE=;\n\tb=Ey2kh95b46jwmxxTfJZizM8cxetL4I0jD1fjKedlJp+xgS6vfMbMBOeuXp6k7LGkc4\n\t16ugtd/9kCPdclTd6ePY9QScHH2J1hoG9c3bla7XxojeKcwNGZcVNg9UmqWitEf/q8Ga\n\tUhxTOep+D6JxxtKBuNyCnWBm0xaB66FFuGUkjHGisosDIP1UVoWgdp7xikz85fgdIEmj\n\t3AKLuD/j03WILygNt2UUkn7HCPzEJ+kZGjpyCxwMDSoMxslJRET3lrCcSe+NY4lkWWu3\n\tshpJBsJbfhEc/UgvlV55A0iRzoNVtZVmQWRL0utuVUSb5G5dMkXlW0ecmuJwcgtPd/iv\n\tzowg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=rdfoQjGn5hqOOYCxvBAN9ITJhTDA0Hwl1+8XEz2sZtE=;\n\tb=VKopbuKlJ8SM6H5j8VWKvWSp35fUL8M9o5OzYMRRcQXFq8N5nOMb7J3t8FDhTacZ0Z\n\t4yF8v+E93arm6AS8z4wj5d2yIGwQKSDw2lbslQXY6QS8lPz5ZDR1lbQjIdJyjmuoIN7V\n\tqbtscJV+wVzsz+CoB3pO3ak58zcIzXD/BIVSLJpoggbDYjiYXzWIus2cVySnpjB+vJ3n\n\trB0+KmsQ8KgbTBfc/cR8nv4zlfMpZz36NWMU3J4Q+Q/y9+MbZxa0YnyA60SQR76mFi0a\n\tP8JKF7/UrjG1bI2r7mRUPK4BMPHRA/GoXmxtwQLYdm3XKH+EvsqfOKQ3FMmTmVX3FTZI\n\tSwnQ==", "X-Gm-Message-State": "ANhLgQ0RwkDOAI99JuJn1iNtmaZZFl6DurWgHowvTjmy/eu2poKHdk12\n\t5BqSb5eYBZNnusxqvT8ciIr0j0gMr+U=", "X-Google-Smtp-Source": "ADFU+vvCYlslo98xu0DXPf+BzJMjban9kMLVaZf5DYdUd/TaSRm03T8hmFWSjTys2IH/FL9umDjxAg==", "X-Received": "by 2002:a17:90a:fa96:: with SMTP id\n\tcu22mr1690974pjb.187.1584490234650; \n\tTue, 17 Mar 2020 17:10:34 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org,\n\tHelen Koike <helen.koike@collabora.com>,\n\tVaishali Thakkar <vthakkar@vaishalithakkar.in>", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "Date": "Wed, 18 Mar 2020 05:40:05 +0530", "Message-Id": "<20200318001009.32512-3-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200318001009.32512-1-kgupta@es.iitr.ac.in>", "References": "<20200318001009.32512-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH LIBCAMERA v2 2/6] libcamera: ipa_proxy:\n\trearrange proxies precedence", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 18 Mar 2020 00:10:36 -0000" }, "content": "User environment path in LIBCAMERA_IPA_PROXY_PATH should take precedence\nover system loading locations. Change precedence accordingly\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/libcamera/ipa_proxy.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex c7347c8..b409e1d 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -75,13 +75,9 @@ IPAProxy::~IPAProxy()\n */\n std::string IPAProxy::resolvePath(const std::string &file) const\n {\n-\t/* Try finding the exec target from the install directory first */\n \tstd::string proxyFile = \"/\" + file;\n-\tstd::string proxyPath = std::string(IPA_PROXY_DIR) + proxyFile;\n-\tif (!access(proxyPath.c_str(), X_OK))\n-\t\treturn proxyPath;\n \n-\t/* No exec target in install directory; check env variable. */\n+\t/* Check env variable first. */\n \tconst char *execPaths = utils::secure_getenv(\"LIBCAMERA_IPA_PROXY_PATH\");\n \tif (execPaths) {\n \t\tfor (const auto &dir : utils::split(execPaths, \":\")) {\n@@ -95,6 +91,11 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n \t\t}\n \t}\n \n+\t/* Try finding the exec target from the install directory. */\n+\tstd::string proxyPath = std::string(IPA_PROXY_DIR) + proxyFile;\n+\tif (!access(proxyPath.c_str(), X_OK))\n+\t\treturn proxyPath;\n+\n \treturn std::string();\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "2/6" ] }