Patch Detail
Show a patch.
GET /api/patches/3142/?format=api
{ "id": 3142, "url": "https://patchwork.libcamera.org/api/patches/3142/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3142/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200317173145.18226-3-kgupta@es.iitr.ac.in>", "date": "2020-03-17T17:31:43", "name": "[libcamera-devel,2/4] libcamera: ipa_proxy: rearrange proxies precedence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ea086bd627fa693ac95d7af37848b7d5072fb424", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3142/mbox/", "series": [ { "id": 727, "url": "https://patchwork.libcamera.org/api/series/727/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=727", "date": "2020-03-17T17:31:41", "name": "libcamera: determine IPA_PROXY_PATH at runtime", "version": 1, "mbox": "https://patchwork.libcamera.org/series/727/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3142/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3142/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pl1-x641.google.com (mail-pl1-x641.google.com\n\t[IPv6:2607:f8b0:4864:20::641])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34A4F62923\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Mar 2020 18:32:29 +0100 (CET)", "by mail-pl1-x641.google.com with SMTP id m1so1718202pll.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Mar 2020 10:32:29 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.153])\n\tby smtp.gmail.com with ESMTPSA id\n\tz16sm3825126pfr.138.2020.03.17.10.32.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Mar 2020 10:32:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=hEIj/Skc1FVs8whHa+MH9fSiE8OXQz904mLGlCZLCvo=;\n\tb=EOVyr6KppWJnX40+5t0q/xcMuTgz9CcblrF9GhrTDFBFyXCFoS+Qe5qbuuDj03EyKt\n\t7mmd0oNaBO+BkUBSiQWjZCjf/L5hTKplI82/kM1TCjWVj3bbEGRWsFaHNVQW44GjryzN\n\tXFI2qyn9pfR9xEdwc39phg+ZaMrscCML6xSHyrMMtLYWrmcLfsKlGRgFz0nojX9xRPKV\n\tyDjnd43AwR06hEC0RfU9q0xUM0aHpP2W1EVw5xrC1oXdzuVdYe5w8IQmsWea9Mn2mcXo\n\tnWjUpSRiQOxHGbMaw+t0ExpRG6HKep1s2x5vwU+1RczGX7wMDbzrvJ7KknlgjNXcpE2+\n\tjD+g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=hEIj/Skc1FVs8whHa+MH9fSiE8OXQz904mLGlCZLCvo=;\n\tb=ZWiyXJizfER1sa/Bhd/uPt2kCVQWLhhTSOGsGuqLZxGmhzmi0bSmhCKbSnqAUa1sSl\n\t2WWU499RGT6h5oub6Uqym6bJljPqiwWBKF8NlnXCt31Jyj+TLPNUqCUubdqUCzqtE2zv\n\tXBaLllcy3Ols4fmOwpYshR0Vj0NeMaO4JBLa7PVvyGrLWA7wZ+hp5kH0AeebS9NuA6mC\n\tz58X+OfU1wl75jAaJAYJeB95mAcjIEd0OXYERoOBO/qyL6YVbQ+okCgfpPRtVSULpU/A\n\tbmuF+3LldBnRVpyjFj3JWuIe+AWQ0xV2k5cQZFB9VpC78VvI6M/iCdOEgQn7dHhKexBa\n\tFybw==", "X-Gm-Message-State": "ANhLgQ3o8U7gFcCp4p3Dh3kvlD2jiwkSGai5/KMP8YOoPfcuZQ13Fx9S\n\thoqUWhQ/UmMC5B2ENt4oC3+zeJEZQ3o=", "X-Google-Smtp-Source": "ADFU+vt319Y2agoaTDvNI27xetX0RPgWWMPnIZdGgx8yw0mS9iObh+xvdrD/58y5q342Oay/SBh40w==", "X-Received": "by 2002:a17:90a:5801:: with SMTP id\n\th1mr286869pji.121.1584466347750; \n\tTue, 17 Mar 2020 10:32:27 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "libcamera-devel@lists.libcamera.org, kieran.bingham@ideasonboard.com,\n\tHelen Koike <helen.koike@collabora.com>,\n\tVaishali Thakkar <vthakkar@vaishalithakkar.in>", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "Date": "Tue, 17 Mar 2020 23:01:43 +0530", "Message-Id": "<20200317173145.18226-3-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200317173145.18226-1-kgupta@es.iitr.ac.in>", "References": "<20200317173145.18226-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH LIBCAMERA 2/4] libcamera: ipa_proxy:\n\trearrange proxies precedence", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 17 Mar 2020 17:32:29 -0000" }, "content": "User environment path in LIBCAMERA_IPA_PROXY_PATH should take precedence\nover system loading locations. Change precedence accordingly.\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/libcamera/ipa_proxy.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex e04117c..363d034 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -75,13 +75,8 @@ IPAProxy::~IPAProxy()\n */\n std::string IPAProxy::resolvePath(const std::string &file) const\n {\n-\t/* Try finding the exec target from the install directory first */\n \tstd::string proxyFile = \"/\" + file;\n-\tstd::string proxyPath = std::string(IPA_PROXY_DIR) + proxyFile;\n-\tif (!access(proxyPath.c_str(), X_OK))\n-\t\treturn proxyPath;\n-\n-\t/* No exec target in install directory; check env variable. */\n+\t/* Check env variable first. */\n \tconst char *execPaths = utils::secure_getenv(\"LIBCAMERA_IPA_PROXY_PATH\");\n \tif (execPaths) {\n \t\tfor (const auto &dir : utils::split(execPaths, \":\")){\n@@ -93,6 +88,12 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n \t\t\t\treturn proxyPath;\n \t\t}\n \t}\n+\n+\t/*Try finding the exec target from the install directory.*/\n+ std::string proxyPath = std::string(IPA_PROXY_DIR) + proxyFile;\n+ if (!access(proxyPath.c_str(), X_OK))\n+ return proxyPath;\n+\n \treturn std::string();\n }\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }