Patch Detail
Show a patch.
GET /api/patches/3135/?format=api
{ "id": 3135, "url": "https://patchwork.libcamera.org/api/patches/3135/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3135/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200317035239.2697679-5-niklas.soderlund@ragnatech.se>", "date": "2020-03-17T03:52:35", "name": "[libcamera-devel,v2,4/8] libcamera: pipeline: uvcvideo: Translate from V4L2 to DRM pixel formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e9b566d36ec1de96a4fb290ccfe4b422173835ff", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3135/mbox/", "series": [ { "id": 726, "url": "https://patchwork.libcamera.org/api/series/726/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=726", "date": "2020-03-17T03:52:31", "name": "libcamera: PixelFormat: Turn into a class", "version": 2, "mbox": "https://patchwork.libcamera.org/series/726/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3135/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3135/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D9D662928\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Mar 2020 04:53:38 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid db0c5851-6802-11ea-aa6d-005056917f90;\n\tTue, 17 Mar 2020 04:53:26 +0100 (CET)" ], "X-Halon-ID": "db0c5851-6802-11ea-aa6d-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 17 Mar 2020 04:52:35 +0100", "Message-Id": "<20200317035239.2697679-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200317035239.2697679-1-niklas.soderlund@ragnatech.se>", "References": "<20200317035239.2697679-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/8] libcamera: pipeline: uvcvideo:\n\tTranslate from V4L2 to DRM pixel formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 17 Mar 2020 03:53:39 -0000" }, "content": "When generating a camera configuration pixel formats directly from the\nvideo device are used that contains V4L2 pixel formats. Translate the\npixel formats to DRM before using them i the camera configuration.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/uvcvideo.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 320da2685795c041..14f7ddb18a765834 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -154,7 +154,14 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n \t\treturn config;\n \n \tImageFormats v4l2formats = data->video_->formats();\n-\tStreamFormats formats(v4l2formats.data());\n+\tstd::map<PixelFormat, std::vector<SizeRange>> deviceformats;\n+\tfor (const auto &it : v4l2formats.data()) {\n+\t\tPixelFormat pixelformat = V4L2VideoDevice::toPixelFormat(it.first);\n+\t\tconst std::vector<SizeRange> &ranges = it.second;\n+\t\tdeviceformats[pixelformat] = ranges;\n+\t}\n+\n+\tStreamFormats formats(deviceformats);\n \tStreamConfiguration cfg(formats);\n \n \tcfg.pixelFormat = formats.pixelformats().front();\n", "prefixes": [ "libcamera-devel", "v2", "4/8" ] }