Patch Detail
Show a patch.
GET /api/patches/3134/?format=api
{ "id": 3134, "url": "https://patchwork.libcamera.org/api/patches/3134/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3134/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200317035239.2697679-4-niklas.soderlund@ragnatech.se>", "date": "2020-03-17T03:52:34", "name": "[libcamera-devel,v2,3/8] libcamera: pipeline: vimc: Remove internal usage of ImageFormats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fbd024780db31559e2f1fa07d55b23377f6694c9", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3134/mbox/", "series": [ { "id": 726, "url": "https://patchwork.libcamera.org/api/series/726/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=726", "date": "2020-03-17T03:52:31", "name": "libcamera: PixelFormat: Turn into a class", "version": 2, "mbox": "https://patchwork.libcamera.org/series/726/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3134/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3134/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CECEE6297B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Mar 2020 04:53:37 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid dab5ef3f-6802-11ea-aa6d-005056917f90;\n\tTue, 17 Mar 2020 04:53:25 +0100 (CET)" ], "X-Halon-ID": "dab5ef3f-6802-11ea-aa6d-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 17 Mar 2020 04:52:34 +0100", "Message-Id": "<20200317035239.2697679-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200317035239.2697679-1-niklas.soderlund@ragnatech.se>", "References": "<20200317035239.2697679-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/8] libcamera: pipeline: vimc: Remove\n\tinternal usage of ImageFormats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 17 Mar 2020 03:53:38 -0000" }, "content": "There is no need to use the ImageFormats helper to generate a map of\nPixelFormat to sizes, use std::map directly.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 8792dfe48ed8db31..72924bf2f55d0021 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -173,17 +173,17 @@ CameraConfiguration *PipelineHandlerVimc::generateConfiguration(Camera *camera,\n \tif (roles.empty())\n \t\treturn config;\n \n-\tImageFormats formats;\n+\tstd::map<PixelFormat, std::vector<SizeRange>> formats;\n \n \tfor (PixelFormat pixelformat : pixelformats) {\n \t\t/* The scaler hardcodes a x3 scale-up ratio. */\n \t\tstd::vector<SizeRange> sizes{\n \t\t\tSizeRange{ 48, 48, 4096, 2160 }\n \t\t};\n-\t\tformats.addFormat(pixelformat, sizes);\n+\t\tformats[pixelformat] = sizes;\n \t}\n \n-\tStreamConfiguration cfg(formats.data());\n+\tStreamConfiguration cfg(formats);\n \n \tcfg.pixelFormat = DRM_FORMAT_BGR888;\n \tcfg.size = { 1920, 1080 };\n", "prefixes": [ "libcamera-devel", "v2", "3/8" ] }