Patch Detail
Show a patch.
GET /api/patches/3123/?format=api
{ "id": 3123, "url": "https://patchwork.libcamera.org/api/patches/3123/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3123/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200316214310.27665-7-laurent.pinchart@ideasonboard.com>", "date": "2020-03-16T21:43:06", "name": "[libcamera-devel,v2,06/10] libcamera: v4l2_videodevice: Downgrade 4CC conversion errors to warnings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e7ca8d46ae58afc8c1c9218728a0afed65278925", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3123/mbox/", "series": [ { "id": 724, "url": "https://patchwork.libcamera.org/api/series/724/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=724", "date": "2020-03-16T21:43:00", "name": "Simple pipeline handler", "version": 2, "mbox": "https://patchwork.libcamera.org/series/724/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3123/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3123/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73AB56299E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Mar 2020 22:43:27 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1ED2AC1;\n\tMon, 16 Mar 2020 22:43:25 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584395007;\n\tbh=qp1IwdmpGTF15rtbkuVBmpldWAU1tfcElyuXFFKBvaE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iJwNDdYM1+hkTtSiJ4h5C21JMkzMTNONENzPwMl0iHF9uHGdMJSodyTsNFiEpStlj\n\tpawWw1y/se1UbasyKyFTJelg/vieXaDWFThQy/aM1LLFckbPjpU2A1vSWcR2ybRdXQ\n\t4tvTh4oMlMfBQqidWddwPrDgajwWUPclqcRZvZP0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Martijn Braam <martijn@brixit.nl>, Mickael GUENE <mickael.guene@st.com>, \n\tBenjamin GAIGNARD <benjamin.gaignard@st.com>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>", "Date": "Mon, 16 Mar 2020 23:43:06 +0200", "Message-Id": "<20200316214310.27665-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200316214310.27665-1-laurent.pinchart@ideasonboard.com>", "References": "<20200316214310.27665-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 06/10] libcamera: v4l2_videodevice:\n\tDowngrade 4CC conversion errors to warnings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 16 Mar 2020 21:43:27 -0000" }, "content": "Failing to convert between V4L2 and DRM 4CCs indicates something is\nlikely wrong, but doesn't necessarily prevent the camera from being\nusable. It may for instance only limit the number of supported formats.\nDowngrade the related log messages from LogError to LogWarning.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex f5a925d97b63..28de3d2fe5c6 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1626,7 +1626,7 @@ PixelFormat V4L2VideoDevice::toPixelFormat(uint32_t v4l2Fourcc)\n \t\t * class. Until we fix the logger, work around it.\n \t\t */\n \t\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n-\t\t\t\tLogError).stream()\n+\t\t\t\tLogWarning).stream()\n \t\t\t<< \"Unsupported V4L2 pixel format \"\n \t\t\t<< utils::hex(v4l2Fourcc);\n \t\treturn 0;\n@@ -1707,7 +1707,8 @@ uint32_t V4L2VideoDevice::toV4L2Fourcc(PixelFormat pixelFormat, bool multiplanar\n \t * \\todo We can't use LOG() in a static method of a Loggable\n \t * class. Until we fix the logger, work around it.\n \t */\n-\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(), LogError).stream()\n+\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n+\t\t\tLogWarning).stream()\n \t\t<< \"Unsupported V4L2 pixel format \"\n \t\t<< utils::hex(pixelFormat);\n \treturn 0;\n", "prefixes": [ "libcamera-devel", "v2", "06/10" ] }