Patch Detail
Show a patch.
GET /api/patches/3091/?format=api
{ "id": 3091, "url": "https://patchwork.libcamera.org/api/patches/3091/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3091/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200313233856.25202-8-laurent.pinchart@ideasonboard.com>", "date": "2020-03-13T23:38:55", "name": "[libcamera-devel,7/8] libcamera: v4l2_videodevice: Map V4L2_PIX_FMT_GREY to DRM FourCC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f8113d1a3b9c2f77ef985909ad9aef91772a2d6c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3091/mbox/", "series": [ { "id": 718, "url": "https://patchwork.libcamera.org/api/series/718/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=718", "date": "2020-03-13T23:38:48", "name": "Simple pipeline handler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/718/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3091/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3091/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E50962928\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 14 Mar 2020 00:39:09 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 683511900;\n\tSat, 14 Mar 2020 00:39:08 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584142749;\n\tbh=l/COplkD/CSkzA9gCu0JsiviApvV0IrCuUFMZpFmhXc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TNUw9aO3lpvd+7+mvHjgH+Zx6us8kzpyMTysKJXVwzJihM7a6/54LyBhW7i/8eYbb\n\tWKA7kfhVl9fvTDmk2aTWplTu08CVcuv9cSAuEkq61i4Go8EfpoiUKJ6+CiZG96LKe7\n\tT0PLyPqEmMKxKVZu9s2QrEBU3/hbKHRhut1HsskM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Martijn Braam <martijn@brixit.nl>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>,\n\tMickael GUENE <mickael.guene@st.com>,\n\tBenjamin GAIGNARD <benjamin.gaignard@st.com>", "Date": "Sat, 14 Mar 2020 01:38:55 +0200", "Message-Id": "<20200313233856.25202-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200313233856.25202-1-laurent.pinchart@ideasonboard.com>", "References": "<20200313233856.25202-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 7/8] libcamera: v4l2_videodevice: Map\n\tV4L2_PIX_FMT_GREY to DRM FourCC", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 13 Mar 2020 23:39:09 -0000" }, "content": "DRM has a format for 8-bit greyscale data, DRM_FORMAT_R8. Despite the\n'R' name, which comes from GL/Vulkan to mean single-channel data, the\nformat maps to greyscale for display. We can thus map it to\nV4L2_PIX_FMT_GREY.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex f68b67b33293..f89bf2ff781e 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1473,12 +1473,15 @@ PixelFormat V4L2VideoDevice::toPixelFormat(uint32_t v4l2Fourcc)\n \tcase V4L2_PIX_FMT_NV21M:\n \t\treturn DRM_FORMAT_NV21;\n \n+\t/* Greyscale formats. */\n+\tcase V4L2_PIX_FMT_GREY:\n+\t\treturn DRM_FORMAT_R8;\n+\n \t/* Compressed formats. */\n \tcase V4L2_PIX_FMT_MJPEG:\n \t\treturn DRM_FORMAT_MJPEG;\n \n \t/* V4L2 formats not yet supported by DRM. */\n-\tcase V4L2_PIX_FMT_GREY:\n \tdefault:\n \t\t/*\n \t\t * \\todo We can't use LOG() in a static method of a Loggable\n@@ -1557,6 +1560,10 @@ uint32_t V4L2VideoDevice::toV4L2Fourcc(PixelFormat pixelFormat, bool multiplanar\n \tcase DRM_FORMAT_NV21:\n \t\treturn V4L2_PIX_FMT_NV21;\n \n+\t/* Greyscale formats. */\n+\tcase DRM_FORMAT_R8:\n+\t\treturn V4L2_PIX_FMT_GREY;\n+\n \t/* Compressed formats. */\n \tcase DRM_FORMAT_MJPEG:\n \t\treturn V4L2_PIX_FMT_MJPEG;\n", "prefixes": [ "libcamera-devel", "7/8" ] }