Patch Detail
Show a patch.
GET /api/patches/3073/?format=api
{ "id": 3073, "url": "https://patchwork.libcamera.org/api/patches/3073/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3073/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200309162414.720306-8-jacopo@jmondi.org>", "date": "2020-03-09T16:24:10", "name": "[libcamera-devel,07/11] libcamera: v4l2_device: Support writing array U8 controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "06dfe5eb6712c8b0d686951a52cf367ef563d397", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3073/mbox/", "series": [ { "id": 716, "url": "https://patchwork.libcamera.org/api/series/716/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=716", "date": "2020-03-09T16:24:03", "name": "Adda support for V4L2 array control and strings", "version": 1, "mbox": "https://patchwork.libcamera.org/series/716/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3073/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3073/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C71C862923\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 17:21:30 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 90E4F6001C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 16:21:30 +0000 (UTC)" ], "X-Originating-IP": "93.34.114.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 9 Mar 2020 17:24:10 +0100", "Message-Id": "<20200309162414.720306-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200309162414.720306-1-jacopo@jmondi.org>", "References": "<20200309162414.720306-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 07/11] libcamera: v4l2_device: Support\n\twriting array U8 controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 09 Mar 2020 16:21:32 -0000" }, "content": "Add support to write array controls of type V4L2_CTRL_TYPE_U8.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_device.cpp | 32 ++++++++++++++++++++++++++++----\n 1 file changed, 28 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 65e97f92b01f..950e6286b84d 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -267,11 +267,25 @@ int V4L2Device::setControls(ControlList *ctrls)\n \t\tcase ControlTypeInteger64:\n \t\t\tv4l2Ctrls[i].value64 = value.get<int64_t>();\n \t\t\tbreak;\n+\t\tcase ControlTypeByte: {\n+\t\t\tif (!value.isArray())\n+\t\t\t\t/*\n+\t\t\t\t * \\todo This happens if a V4L2_CTRL_TYPE_U8\n+\t\t\t\t * control is set with a non-array ControlValue.\n+\t\t\t\t *\n+\t\t\t\t * Should we fail loudly here ?\n+\t\t\t\t */\n+\t\t\t\tbreak;\n+\n+\t\t\tauto values = value.get<Span<const uint8_t>>();\n+\t\t\tv4l2Ctrls[i].p_u8 = const_cast<uint8_t *>(values.data());\n+\t\t\tv4l2Ctrls[i].size = values.size_bytes();\n+\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tdefault:\n-\t\t\t/*\n-\t\t\t * \\todo To be changed when support for string and\n-\t\t\t * compound controls will be added.\n-\t\t\t */\n+\t\t\t/* \\todo To be changed to support strings. */\n \t\t\tv4l2Ctrls[i].value = value.get<int32_t>();\n \t\t\tbreak;\n \t\t}\n@@ -413,6 +427,16 @@ void V4L2Device::updateControls(ControlList *ctrls,\n \t\tcase ControlTypeInteger64:\n \t\t\tvalue.set<int64_t>(v4l2Ctrl->value64);\n \t\t\tbreak;\n+\n+\t\tcase ControlTypeByte: {\n+\t\t\tstd::vector<uint8_t> data = {\n+\t\t\t\tv4l2Ctrl->p_u8, v4l2Ctrl->p_u8 + v4l2Ctrl->size\n+\t\t\t};\n+\t\t\tSpan<const uint8_t> values(data);\n+\t\t\tvalue.set<Span<const uint8_t>>(values);\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tdefault:\n \t\t\t/*\n \t\t\t * \\todo To be changed when support for string and\n", "prefixes": [ "libcamera-devel", "07/11" ] }