Patch Detail
Show a patch.
GET /api/patches/3061/?format=api
{ "id": 3061, "url": "https://patchwork.libcamera.org/api/patches/3061/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3061/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200309123319.630-4-naush@raspberrypi.com>", "date": "2020-03-09T12:33:16", "name": "[libcamera-devel,v2,3/6] libcamera: controls: Add AE related controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fcff9b2e7fbe103ca29f15a2491c193077f45eeb", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3061/mbox/", "series": [ { "id": 715, "url": "https://patchwork.libcamera.org/api/series/715/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=715", "date": "2020-03-09T12:33:13", "name": "Patchset for libcamera controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/715/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3061/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3061/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6664C62923\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 13:35:35 +0100 (CET)", "by mail-wr1-x442.google.com with SMTP id v11so10850392wrm.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 09 Mar 2020 05:35:35 -0700 (PDT)", "from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\tz135sm25693827wmc.20.2020.03.09.05.35.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Mar 2020 05:35:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=vIBOmEPiN9DPLPXp5Nwe4wgfwUUdjRgobQ695qMK1iM=;\n\tb=CNIYZ+APaojZX8+6HhzuNp4KFNE3sexp8ueSLdCD97IsviESraOu+WlsVmjAIqCBXQ\n\tGONJ196Dirh29f43wP5HDYWmdDqjEHOxnV1FAun/zUZum/HEg6pEQg6zhq+46u4Nauu0\n\tCLAq3jFPL9MwLNbJbJVdUnK1pkps6BolevQ3VwGAPxoynG2/ZBJX0S9vjBc/Qc50ygLq\n\tG/MtVYjBO2lwls4MHzxJWQEMRxzHooivZD5p+vrL6vOggqBoWxqBKOvrl6IktcpO31U+\n\t/d/HvmH1NodMuBA6x4tDS8QxPBgShb3kxJaxAievBtHl/brzrdTUqa7qm+6Lt2WDlqDD\n\tzxdg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vIBOmEPiN9DPLPXp5Nwe4wgfwUUdjRgobQ695qMK1iM=;\n\tb=V070UnYxdvYf6EqMWcmICXwmYYN2MgaecnyutKi+XyFlauueuz5CY/s8ZFG6nhEVJm\n\t08FFC9d2rk7NO6Gcq3pHRVQ7l7OXK8JWsudiozfJWm3Mhi5WfsEIynME8cuEqA0XamZw\n\tQn3G3ocygT/S3agsZMdBdcnendZ1LLijrVIQDR+/67Ri0b/BCWAez8m2aI6bmMbrbPG3\n\tWBVtgOIbcNCTtZRFnsTiS5re9zStxyzEZE5hSIiqEV3EoUPCpZZ+RGk6mWlDaV8VQ/m/\n\tGrPZklOIvL2NanCw2xuvxGSZnZlEbxO0Enbegb5hbvugzJN8EJC58OqViMbgh6lCSJFw\n\tih9w==", "X-Gm-Message-State": "ANhLgQ2EqrkOLn73stXrA/Cxlx0V6/sB2fljFgbq6Ef2AvMY7Bvaknqu\n\t8Hj/6W3br/8VaQgUsNIaio9aQlzl9vcVUg==", "X-Google-Smtp-Source": "ADFU+vuBjOY59vU+XCpb9sKvPtyKwS9tAz0uUZJ0lywwz0cCBoZppJbPQjng3VRm82vJj/ILj3vIEg==", "X-Received": "by 2002:adf:82ee:: with SMTP id 101mr20626058wrc.7.1583757334843;\n\tMon, 09 Mar 2020 05:35:34 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 9 Mar 2020 12:33:16 +0000", "Message-Id": "<20200309123319.630-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200309123319.630-1-naush@raspberrypi.com>", "References": "<20200309123319.630-1-naush@raspberrypi.com>", "Subject": "[libcamera-devel] [PATCH v2 3/6] libcamera: controls: Add AE\n\trelated controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 09 Mar 2020 12:35:35 -0000" }, "content": "AeMeteringMode, AeConstraintMode, and AeExposureMode are new enum type\ncontrols used to specify operating modes in the AE algorithm. All modes\nmay not be supported by all platforms.\n\nExposureValue is a new double type control used to set the log2 exposure\nadjustment for the AE algorithm.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 121 +++++++++++++++++++++++++++++----\n 1 file changed, 109 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 5bbe65ae..da1a7b43 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -23,24 +23,104 @@ controls:\n \n \\sa AeEnable\n \n- - AwbEnable:\n- type: bool\n+ - AeMeteringMode:\n+ type: int32_t\n description: |\n- Enable or disable the AWB.\n-\n- \\sa ManualGain\n+ Specify a metering mode for the AE algorithm to use. The metering\n+ modes determine which parts of the image are used to determine the\n+ scene brightness. Metering modes may be platform-specific and not\n+ all metering modes may be supported.\n+ enum:\n+ - name: MeteringCentreWeighted\n+ value: 0\n+ description: Centre-weighted metering mode.\n+ - name: MeteringSpot\n+ value: 1\n+ description: Spot metering mode.\n+ - name: MeteringMatrix\n+ value: 2\n+ description: Matrix metering mode.\n+ - name: MeteringCustom1\n+ value: 3\n+ description: Custom metering mode 1.\n+ - name: MeteringCustom2\n+ value: 4\n+ description: Custom metering mode 2.\n+ - name: MeteringCustom3\n+ value: 5\n+ description: Custom metering mode 3.\n+ - name: MeteringModeMax\n+ value: 5\n+ description: Maximum allowed value (place any new values above here).\n \n- - Brightness:\n+ - AeConstraintMode:\n type: int32_t\n- description: Specify a fixed brightness parameter\n+ description: |\n+ Specify a constraint mode for the AE algorithm to use. These determine\n+ how the measured scene brightness is adjusted to reach the desired\n+ target exposure. Constraint modes may be platform specific, and not\n+ all constaint modes may be supported.\n+ enum:\n+ - name: ConstraintNormal\n+ value: 0\n+ description: Default constraint mode.\n+ - name: ConstraintHighlight\n+ value: 1\n+ description: Highlight constraint mode.\n+ - name: ConstraintCustom1\n+ value: 2\n+ description: Custom constraint mode 1.\n+ - name: ConstraintCustom2\n+ value: 3\n+ description: Custom constraint mode 2.\n+ - name: ConstraintCustom3\n+ value: 4\n+ description: Custom constraint mode 3.\n+ - name: ConstraintModeMax\n+ value: 4\n+ description: Maximum allowed value (place any new values above here).\n \n- - Contrast:\n+ - AeExposureMode:\n type: int32_t\n- description: Specify a fixed contrast parameter\n+ description: |\n+ Specify an exposure mode for the AE algorithm to use. These specify\n+ how the desired total exposure is divided between the shutter time\n+ and the sensor's analogue gain. The exposure modes are platform\n+ spcific, and not all exposure modes may be supported.\n+ enum:\n+ - name: ExposureNormal\n+ value: 0\n+ description: Default metering mode.\n+ - name: ExposureSport\n+ value: 1\n+ description: Sport metering mode (favouring short shutter times).\n+ - name: ExposureLong\n+ value: 2\n+ description: Exposure mode allowing long exposure times.\n+ - name: ExposureCustom1\n+ value: 3\n+ description: Custom exposure mode 1.\n+ - name: ExposureCustom2\n+ value: 4\n+ description: Custom exposure mode 2.\n+ - name: ExposureCustom3\n+ value: 5\n+ description: Custom exposure mode 3.\n+ - name: ExposureModeMax\n+ value: 5\n+ description: Maximum allowed value (place any new values above here).\n \n- - Saturation:\n- type: int32_t\n- description: Specify a fixed saturation parameter\n+ - ExposureValue:\n+ type: float\n+ description: |\n+ Specify an Exposure Value (EV) parameter. The EV parameter will only be\n+ applied if the AE alogrithm is currently enabled.\n+\n+ By convention EV adjusts the exposure as log2. For example\n+ EV = [-2, -1, 0.5, 0, 0.5, 1, 2] results in an exposure adjustment\n+ of [1/4x, 1/2x, 1/sqrt(2)x, 1x, sqrt(2)x, 2x, 4x].\n+\n+ \\sa AeEnable\n \n - ManualExposure:\n type: int32_t\n@@ -57,4 +137,21 @@ controls:\n applied to all colour channels.\n \n \\sa ManualExposure\n+\n+ - AwbEnable:\n+ type: bool\n+ description: |\n+ Enable or disable the AWB.\n+\n+ - Brightness:\n+ type: int32_t\n+ description: Specify a fixed brightness parameter\n+\n+ - Contrast:\n+ type: int32_t\n+ description: Specify a fixed contrast parameter\n+\n+ - Saturation:\n+ type: int32_t\n+ description: Specify a fixed saturation parameter\n ...\n", "prefixes": [ "libcamera-devel", "v2", "3/6" ] }