Patch Detail
Show a patch.
GET /api/patches/3055/?format=api
{ "id": 3055, "url": "https://patchwork.libcamera.org/api/patches/3055/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3055/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200308000433.2917-5-laurent.pinchart@ideasonboard.com>", "date": "2020-03-08T00:04:31", "name": "[libcamera-devel,v4,4/6] libcamera: meson: Make libatomic and libdl dependencies reusable", "commit_ref": "61aa357a95dcb52537fba85fab58038ae9d6a97a", "pull_url": null, "state": "accepted", "archived": false, "hash": "6f7e84048e8b7803fe2f0b42ae44eab94b75f20d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3055/mbox/", "series": [ { "id": 714, "url": "https://patchwork.libcamera.org/api/series/714/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=714", "date": "2020-03-08T00:04:27", "name": "Fix race condition and other build issues", "version": 4, "mbox": "https://patchwork.libcamera.org/series/714/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3055/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3055/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 166D66290B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 8 Mar 2020 01:04:44 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A7A35F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 8 Mar 2020 01:04:43 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583625883;\n\tbh=Xr/8CBqTGieD+ntHJqYWs0pLWt229d1lqcTQ91nj2Cg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=JbffzMg47DQBBo/0Mat153CBKs22MM7OoyVhkXIK1vniisI9mJ4Q1qfXsV3lJs3se\n\tAzMk4brZXbGR460vsVFqQ+o3Jf8NLhnElxzDB7U7OvKnq3KdaF1vcDSOd/PemvjT8h\n\tq5zE2stDyIcYMD/wGk9wNZ+ht0Q7ggRVVeG+C8Lw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 8 Mar 2020 02:04:31 +0200", "Message-Id": "<20200308000433.2917-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>", "References": "<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/6] libcamera: meson: Make libatomic\n\tand libdl dependencies reusable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 08 Mar 2020 00:04:45 -0000" }, "content": "libcamera.so links against libatomic and libdl, and handles those\ndependencies directly in the shared_object() call. More components\nwithin libcamera will need those dependencies, extract them to named\nvariables to make them reusable.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 1b69bc0dee54..87fa09cde63d 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -58,6 +58,8 @@ includes = [\n subdir('pipeline')\n subdir('proxy')\n \n+libatomic = cc.find_library('atomic', required : false)\n+libdl = cc.find_library('dl')\n libudev = dependency('libudev', required : false)\n \n if libudev.found()\n@@ -93,8 +95,8 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],\n libcamera_sources += version_cpp\n \n libcamera_deps = [\n- cc.find_library('atomic', required: false),\n- cc.find_library('dl'),\n+ libatomic,\n+ libdl,\n libudev,\n dependency('threads'),\n ]\n", "prefixes": [ "libcamera-devel", "v4", "4/6" ] }