Patch Detail
Show a patch.
GET /api/patches/3047/?format=api
{ "id": 3047, "url": "https://patchwork.libcamera.org/api/patches/3047/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3047/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200307211326.26994-8-laurent.pinchart@ideasonboard.com>", "date": "2020-03-07T21:13:26", "name": "[libcamera-devel,v3,7/7] libcamera: Declare dependency on generated headers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dec911506a4beea73f1c1c273b8b90e75bc83b10", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3047/mbox/", "series": [ { "id": 710, "url": "https://patchwork.libcamera.org/api/series/710/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=710", "date": "2020-03-07T21:13:19", "name": "Fix race condition and other build issues", "version": 3, "mbox": "https://patchwork.libcamera.org/series/710/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3047/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3047/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54BBE628E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 7 Mar 2020 22:13:40 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDA9924B;\n\tSat, 7 Mar 2020 22:13:39 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583615620;\n\tbh=Cm5nswTA5+burNLwZAXRR6F5EtulJQGauPiG6I7Pf/4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=C1oQMa+unUdD4hRrSts+HPPIpBOmmyxgevnL7joObHgWO9ubw3uhjW6uhSFVUGpkd\n\tkVBhLSJ5/NXgi6SOlS/myza985jOFQAckW662rLiXpxd/Lz21OMzOIhFMX35tSh4dM\n\tFYPEVNUAXtmHT6jQ8lFFmi966q646AZ/tWkw2sO4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 7 Mar 2020 23:13:26 +0200", "Message-Id": "<20200307211326.26994-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200307211326.26994-1-laurent.pinchart@ideasonboard.com>", "References": "<20200307211326.26994-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 7/7] libcamera: Declare dependency on\n\tgenerated headers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 07 Mar 2020 21:13:41 -0000" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nThe control headers are generated automatically by parsing our YAML\ndescriptions, and creating the control headers.\n\nThese headers are included by internal libcamera source files, but the\nbuild system isn't informed of this dependency. This allows a race\ncondition to occur in builds where objects are attempted to be built\nbefore the included headers have been generated, resulting in a build\nfailure or, worse, in a successful but incorrect build.\n\nDeclare a dependency on the control headers for libcamera to ensure that\nthey are built before compiling any object within the libcamera library.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n[Split the change out and reworded commit message]\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex ac6f597c6188..692ca5899f3a 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -97,6 +97,7 @@ libcamera_deps = [\n cc.find_library('dl'),\n libudev,\n dependency('threads'),\n+ declare_dependency(sources : [control_headers])\n ]\n \n libcamera_link_with = []\n", "prefixes": [ "libcamera-devel", "v3", "7/7" ] }