Patch Detail
Show a patch.
GET /api/patches/3031/?format=api
{ "id": 3031, "url": "https://patchwork.libcamera.org/api/patches/3031/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3031/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306202637.525587-26-nicolas@ndufresne.ca>", "date": "2020-03-06T20:26:35", "name": "[libcamera-devel,v3,25/27] gst: utils: Factor-out the task resume helper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ca302e8e7bdd7888c220843a21b612cf471d777", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3031/mbox/", "series": [ { "id": 705, "url": "https://patchwork.libcamera.org/api/series/705/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=705", "date": "2020-03-06T20:26:10", "name": "GStreamer Element for libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/705/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3031/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3031/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01B70628B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 21:27:13 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 70039297190;\n\tFri, 6 Mar 2020 20:27:12 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jakub Adam <jakub.adam@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 6 Mar 2020 15:26:35 -0500", "Message-Id": "<20200306202637.525587-26-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "References": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 25/27] gst: utils: Factor-out the task\n\tresume helper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 20:27:13 -0000" }, "content": "From: Jakub Adam <jakub.adam@collabora.com>\n\nTask resume will be added in the core GStreamer API in the future and\nwe will need to call this in another location in the following patches.\n\nSigned-off-by: Jakub Adam <jakub.adam@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 11 +++++++++++\n src/gstreamer/gstlibcamera-utils.h | 1 +\n src/gstreamer/gstlibcamerasrc.cpp | 10 +---------\n 3 files changed, 13 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 482439a..44a993f 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -167,3 +167,14 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n \tstream_cfg.size.width = width;\n \tstream_cfg.size.height = height;\n }\n+\n+void\n+gst_libcamera_resume_task(GstTask *task)\n+{\n+\t/* We only want to resume the task if it's paused. */\n+\tGLibLocker lock(GST_OBJECT(task));\n+\tif (GST_TASK_STATE(task) == GST_TASK_PAUSED) {\n+\t\tGST_TASK_STATE(task) = GST_TASK_STARTED;\n+\t\tGST_TASK_SIGNAL(task);\n+\t}\n+}\ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex cbfb1cc..2b3f26b 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -18,6 +18,7 @@ GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &fo\n GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg);\n void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n \t\t\t\t\t GstCaps *caps);\n+void gst_libcamera_resume_task(GstTask *task);\n \n /**\n * \\class GLibLocker\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 8d0d0e1..22d9175 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -196,15 +196,7 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \t\tgst_libcamera_pad_queue_buffer(srcpad, buffer);\n \t}\n \n-\t{\n-\t\t/* We only want to resume the task if it's paused. */\n-\t\tGstTask *task = src_->task;\n-\t\tGLibLocker lock(GST_OBJECT(task));\n-\t\tif (GST_TASK_STATE(task) == GST_TASK_PAUSED) {\n-\t\t\tGST_TASK_STATE(task) = GST_TASK_STARTED;\n-\t\t\tGST_TASK_SIGNAL(task);\n-\t\t}\n-\t}\n+\tgst_libcamera_resume_task(this->src_->task);\n }\n \n static bool\n", "prefixes": [ "libcamera-devel", "v3", "25/27" ] }