Patch Detail
Show a patch.
GET /api/patches/3029/?format=api
{ "id": 3029, "url": "https://patchwork.libcamera.org/api/patches/3029/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3029/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306202637.525587-24-nicolas@ndufresne.ca>", "date": "2020-03-06T20:26:33", "name": "[libcamera-devel,v3,23/27] gst: libcamerasrc: Implement timestamp support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "aa26bf302ebb4153a376002e3827d6bd1a2e5c64", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3029/mbox/", "series": [ { "id": 705, "url": "https://patchwork.libcamera.org/api/series/705/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=705", "date": "2020-03-06T20:26:10", "name": "GStreamer Element for libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/705/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3029/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3029/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC4E562795\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 21:27:11 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 59DFF297190;\n\tFri, 6 Mar 2020 20:27:11 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 6 Mar 2020 15:26:33 -0500", "Message-Id": "<20200306202637.525587-24-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "References": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 23/27] gst: libcamerasrc: Implement\n\ttimestamp support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 20:27:12 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThis is an experimental patch adding timestamp support to the libcamerasrc\nelement. This patch currently assume that the driver timestamp are relative to\nthe system monotonic clock. Without a reference clock source, the timestamp are\notherwise unusable, and without timestamp only minor use case can be achieved.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 23 +++++++++++++++++++++++\n src/gstreamer/gstlibcamerapad.h | 2 ++\n src/gstreamer/gstlibcamerasrc.cpp | 20 ++++++++++++++++++++\n 3 files changed, 45 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 840f391..e184495 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -63,9 +63,24 @@ gst_libcamera_pad_get_property(GObject *object, guint prop_id, GValue *value,\n \t}\n }\n \n+static gboolean\n+gst_libcamera_pad_query(GstPad *pad, GstObject *parent, GstQuery *query)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\n+\tif (query->type != GST_QUERY_LATENCY)\n+\t\treturn gst_pad_query_default(pad, parent, query);\n+\n+\t/* TRUE here means live, we assumes that max latency is the same as min\n+\t * as we have no idea that duration of frames. */\n+\tgst_query_set_latency(query, TRUE, self->latency, self->latency);\n+\treturn TRUE;\n+}\n+\n static void\n gst_libcamera_pad_init(GstLibcameraPad *self)\n {\n+\tGST_PAD_QUERYFUNC(self) = gst_libcamera_pad_query;\n }\n \n static GType\n@@ -173,3 +188,11 @@ gst_libcamera_pad_has_pending(GstPad *pad)\n \tGLibLocker lock(GST_OBJECT(self));\n \treturn self->pending_buffers.length > 0;\n }\n+\n+void\n+gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGLibLocker lock(GST_OBJECT(self));\n+\tself->latency = latency;\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 9d43129..779f2d1 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -32,4 +32,6 @@ GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\n \n bool gst_libcamera_pad_has_pending(GstPad *pad);\n \n+void gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency);\n+\n #endif /* __GST_LIBCAMERA_PAD_H__ */\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex e3718db..b04e9f1 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -154,6 +154,26 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \tfor (GstPad *srcpad : srcpads_) {\n \t\tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n \t\tbuffer = wrap->detachBuffer(stream);\n+\n+\t\tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n+\n+\t\tif (GST_ELEMENT_CLOCK(src_)) {\n+\t\t\tGstClockTime gst_base_time = GST_ELEMENT(src_)->base_time;\n+\t\t\tGstClockTime gst_now = gst_clock_get_time(GST_ELEMENT_CLOCK(src_));\n+\t\t\t/* \\todo Need to expose which reference clock the timestamp relates to. */\n+\t\t\tGstClockTime sys_now = g_get_monotonic_time() * 1000;\n+\n+\t\t\t/* Deduced from: sys_now - sys_base_time == gst_now - gst_base_time */\n+\t\t\tGstClockTime sys_base_time = sys_now - (gst_now - gst_base_time);\n+\t\t\tGST_BUFFER_PTS(buffer) = fb->metadata().timestamp - sys_base_time;\n+\t\t\tgst_libcamera_pad_set_latency(srcpad, sys_now - fb->metadata().timestamp);\n+\t\t} else {\n+\t\t\tGST_BUFFER_PTS(buffer) = 0;\n+\t\t}\n+\n+\t\tGST_BUFFER_OFFSET(buffer) = fb->metadata().sequence;\n+\t\tGST_BUFFER_OFFSET_END(buffer) = fb->metadata().sequence;\n+\n \t\tgst_libcamera_pad_queue_buffer(srcpad, buffer);\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "23/27" ] }