Patch Detail
Show a patch.
GET /api/patches/2994/?format=api
{ "id": 2994, "url": "https://patchwork.libcamera.org/api/patches/2994/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2994/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306160002.30549-23-laurent.pinchart@ideasonboard.com>", "date": "2020-03-06T15:59:52", "name": "[libcamera-devel,v2,22/32] libcamera: ipa: Support array controls in ipa_control_value_entry", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "654f9b41b5ba3006ad57267e86b967b812e95d19", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2994/mbox/", "series": [ { "id": 703, "url": "https://patchwork.libcamera.org/api/series/703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=703", "date": "2020-03-06T15:59:30", "name": "libcamera: Add support for array controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2994/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2994/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56EA562895\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:24 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E54DAA48\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:23 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510424;\n\tbh=/UMbelP5S1DFbAsOKVftaI9xKR3VpHsTizm9OsiyD8s=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=anvAbvOPBSwaTTIeA4v99Vatu39UYiAGZ8hcGXHCiRSm4LoyZzOVAD4DvYpdAXinp\n\t47vDJGC9BUNFu+gs9xUvsUf9NAnFZ8gZW3Gn470n8HCbJio/cWfwkm7HIFbQZw9G62\n\tQH061beIGzxgrdC0k9B7E3reW5edcvcSF63NXU4M=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Mar 2020 17:59:52 +0200", "Message-Id": "<20200306160002.30549-23-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "References": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 22/32] libcamera: ipa: Support array\n\tcontrols in ipa_control_value_entry", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 16:00:25 -0000" }, "content": "Report in a new field of the ipa_control_value_entry structure if the\nvalue contains an array. Reorganize the other fields of the structure to\navoid increasing its size.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/ipa/ipa_controls.h | 6 ++++--\n src/libcamera/ipa_controls.cpp | 4 ++++\n 2 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/ipa/ipa_controls.h b/include/ipa/ipa_controls.h\nindex 6371e34575f2..37f97d6ad2a4 100644\n--- a/include/ipa/ipa_controls.h\n+++ b/include/ipa/ipa_controls.h\n@@ -26,9 +26,11 @@ struct ipa_controls_header {\n \n struct ipa_control_value_entry {\n \tuint32_t id;\n-\tuint32_t type;\n-\tuint32_t count;\n+\tuint8_t type;\n+\tuint8_t is_array;\n+\tuint16_t count;\n \tuint32_t offset;\n+\tuint32_t padding[1];\n };\n \n struct ipa_control_range_entry {\ndiff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\nindex fc5ccd4210b2..da4724b178e2 100644\n--- a/src/libcamera/ipa_controls.cpp\n+++ b/src/libcamera/ipa_controls.cpp\n@@ -163,11 +163,15 @@ static_assert(sizeof(ipa_controls_header) == 32,\n * The numerical ID of the control\n * \\var ipa_control_value_entry::type\n * The type of the control (defined by enum ControlType)\n+ * \\var ipa_control_value_entry::is_array\n+ * True if the control value stores an array, false otherwise\n * \\var ipa_control_value_entry::count\n * The number of control array entries for array controls (1 otherwise)\n * \\var ipa_control_value_entry::offset\n * The offset in bytes from the beginning of the data section to the control\n * value data (shall be a multiple of 8 bytes).\n+ * \\var ipa_control_value_entry::padding\n+ * Padding bytes (shall be set to 0)\n */\n \n static_assert(sizeof(ipa_control_value_entry) == 16,\n", "prefixes": [ "libcamera-devel", "v2", "22/32" ] }