Patch Detail
Show a patch.
GET /api/patches/2993/?format=api
{ "id": 2993, "url": "https://patchwork.libcamera.org/api/patches/2993/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2993/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306160002.30549-22-laurent.pinchart@ideasonboard.com>", "date": "2020-03-06T15:59:51", "name": "[libcamera-devel,v2,21/32] libcamera: controls: Convert bool ControlValue to lowercase strings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4cfb7a4b0f055450beb07641c12ee4a1b3afb900", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2993/mbox/", "series": [ { "id": 703, "url": "https://patchwork.libcamera.org/api/series/703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=703", "date": "2020-03-06T15:59:30", "name": "libcamera: Add support for array controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2993/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2993/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0066F628A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:24 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93A3F24B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:23 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510423;\n\tbh=RkzQicivtlWkMIm0eHjiuGRnhvtl/p1tEGUu+UUN38A=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=V8ORNGZxTHdU7FA/iFKo0fh3pR0Y+jsXVEwhmB2hjC8d/bh8El1uBywgfxTJkfb1L\n\txutqJm8Kg5F+zmhxhF77fQN4eQfQUeODYZTsubZ/CoKiry34BUwbtmYDzUTfH2u88e\n\tPelWJ0mCVAMA9UdI1X7TWi7/FECpqXk29vEpWWcM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Mar 2020 17:59:51 +0200", "Message-Id": "<20200306160002.30549-22-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "References": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 21/32] libcamera: controls: Convert\n\tbool ControlValue to lowercase strings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 16:00:24 -0000" }, "content": "The C++ boolean types are lower case, and std::ostream::operator<<(bool)\nproduces a lowercase string (when std::boolalpha is in effect, otherwise\nit produces 0 or 1). Switch ControlValue::toString() to produce\nlowercase \"true\" and \"false\" strings too for consistency.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/controls.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 0663a2201609..94bdbdd9c388 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -198,7 +198,7 @@ std::string ControlValue::toString() const\n \t\tswitch (type_) {\n \t\tcase ControlTypeBool: {\n \t\t\tconst bool *value = reinterpret_cast<const bool *>(data);\n-\t\t\tstr += *value ? \"True\" : \"False\";\n+\t\t\tstr += *value ? \"true\" : \"false\";\n \t\t\tbreak;\n \t\t}\n \t\tcase ControlTypeByte: {\n", "prefixes": [ "libcamera-devel", "v2", "21/32" ] }