Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2961,
    "url": "https://patchwork.libcamera.org/api/patches/2961/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/2961/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200304232246.325384-6-niklas.soderlund@ragnatech.se>",
    "date": "2020-03-04T23:22:44",
    "name": "[libcamera-devel,v3,5/7] libcamera: V4L2BufferCache: Check for hot hit first",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "04d03850cb3eb4262dcaacfdf90c940eb144d47c",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/2961/mbox/",
    "series": [
        {
            "id": 701,
            "url": "https://patchwork.libcamera.org/api/series/701/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=701",
            "date": "2020-03-04T23:22:39",
            "name": "libcamera: V4L2BufferCache: Improve cache",
            "version": 3,
            "mbox": "https://patchwork.libcamera.org/series/701/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/2961/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/2961/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE0A86287F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  5 Mar 2020 00:23:47 +0100 (CET)",
            "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 3286f990-5e6f-11ea-9f85-005056917a89;\n\tThu, 05 Mar 2020 00:23:47 +0100 (CET)"
        ],
        "X-Halon-ID": "3286f990-5e6f-11ea-9f85-005056917a89",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Thu,  5 Mar 2020 00:22:44 +0100",
        "Message-Id": "<20200304232246.325384-6-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20200304232246.325384-1-niklas.soderlund@ragnatech.se>",
        "References": "<20200304232246.325384-1-niklas.soderlund@ragnatech.se>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v3 5/7] libcamera: V4L2BufferCache: Check\n\tfor hot hit first",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Wed, 04 Mar 2020 23:23:48 -0000"
    },
    "content": "Check for a hot cache hit before updating which buffer is best to evict\nin case no hot hit is found.\n\nSuggested-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/v4l2_videodevice.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 268de60bc7965f58..c495de85f26efe14 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -212,15 +212,15 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n \t\tif (!entry.free)\n \t\t\tcontinue;\n \n-\t\tif (use < 0)\n-\t\t\tuse = index;\n-\n \t\t/* Try to find a cache hit by comparing the planes. */\n \t\tif (entry == buffer) {\n \t\t\thit = true;\n \t\t\tuse = index;\n \t\t\tbreak;\n \t\t}\n+\n+\t\tif (use < 0)\n+\t\t\tuse = index;\n \t}\n \n \tif (!hit)\n",
    "prefixes": [
        "libcamera-devel",
        "v3",
        "5/7"
    ]
}