Patch Detail
Show a patch.
GET /api/patches/2950/?format=api
{ "id": 2950, "url": "https://patchwork.libcamera.org/api/patches/2950/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2950/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>", "date": "2020-03-01T16:02:54", "name": "[libcamera-devel] libcamera: control_serializer: Use explicit ControlTypeNone case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c544c285e5abc4737d9bcebee2d4992cd74a06a9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2950/mbox/", "series": [ { "id": 697, "url": "https://patchwork.libcamera.org/api/series/697/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=697", "date": "2020-03-01T16:02:54", "name": "[libcamera-devel] libcamera: control_serializer: Use explicit ControlTypeNone case", "version": 1, "mbox": "https://patchwork.libcamera.org/series/697/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2950/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2950/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E539D60429\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 1 Mar 2020 17:03:22 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50B0154A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 1 Mar 2020 17:03:22 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583078602;\n\tbh=SA98HRbEPrexqGYE3h5QRWjoAfw0BtpNUoWgEpsvlSQ=;\n\th=From:To:Subject:Date:From;\n\tb=ALgXW73woRnPERJKnYq44wwz8htWv5YOb1HBjBPxFLTMt8mBQT9w7sZbXTzmXxOeh\n\tBmveGdd5j9Mlw0JCgZ6DQJJs3MakRYL0grg5zbEEs3w/LUflHC63pgdyM5ASj/SIrh\n\tDliglv//GU+BBBBVjhLY+N0exxic82ZWiMD/GHS8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 1 Mar 2020 18:02:54 +0200", "Message-Id": "<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 01 Mar 2020 16:03:23 -0000" }, "content": "Replace the default case with an explicit ControlTypeNone case in\nControlSerializer::load() to catch ommissions when adding new control\ntypes.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/control_serializer.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex 5537c5466025..e78fca88cfea 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -361,7 +361,7 @@ ControlValue ControlSerializer::load<ControlValue>(ControlType type,\n \t\treturn ControlValue(value);\n \t}\n \n-\tdefault:\n+\tcase ControlTypeNone:\n \t\treturn ControlValue();\n \t}\n }\n", "prefixes": [ "libcamera-devel" ] }