Patch Detail
Show a patch.
GET /api/patches/2938/?format=api
{ "id": 2938, "url": "https://patchwork.libcamera.org/api/patches/2938/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2938/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200229164254.23604-20-laurent.pinchart@ideasonboard.com>", "date": "2020-02-29T16:42:42", "name": "[libcamera-devel,19/31] libcamera: controls: Add support for float controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d909b8744034452ce679c9e6192ccc252d073e8b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2938/mbox/", "series": [ { "id": 696, "url": "https://patchwork.libcamera.org/api/series/696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=696", "date": "2020-02-29T16:42:23", "name": "libcamera: Add support for array controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2938/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2938/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEACF6278B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 17:43:28 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 755BAA28;\n\tSat, 29 Feb 2020 17:43:28 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582994608;\n\tbh=2T97E/upi6cYLoYbYWlfeMfQCGIfeR85Ph86ju/H8bw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N69glqaxREmsNH/jbSpy6uvgyYT9OJ6Xqm7FzgfVArFC5MFgLCn/gTYybHsM6Tda1\n\tFMWRZaRgCJEsdKFSDnvkoJY/V8Lo0ysqI+abTYkiymLziuxb3F5qa4icafvnP0VXcf\n\tpvwhpxIEgIaQ3M+Ajq4gjMF3m3QZ+69o/Ao5EdnA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 29 Feb 2020 18:42:42 +0200", "Message-Id": "<20200229164254.23604-20-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "References": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 19/31] libcamera: controls: Add support\n\tfor float controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 29 Feb 2020 16:43:35 -0000" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nAdd support for float values in Control<> and ControlValue classes.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/controls.h | 6 ++++++\n src/libcamera/control_serializer.cpp | 12 ++++++++++++\n src/libcamera/controls.cpp | 14 +++++++++++---\n 3 files changed, 29 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex f99c90e934c1..97a662e3f4a6 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -24,6 +24,7 @@ enum ControlType {\n \tControlTypeBool,\n \tControlTypeInteger32,\n \tControlTypeInteger64,\n+\tControlTypeFloat,\n };\n \n namespace details {\n@@ -52,6 +53,11 @@ struct control_type<int64_t> {\n \tstatic constexpr ControlType value = ControlTypeInteger64;\n };\n \n+template<>\n+struct control_type<float> {\n+\tstatic constexpr ControlType value = ControlTypeFloat;\n+};\n+\n template<typename T, std::size_t N>\n struct control_type<Span<T, N>> : public control_type<std::remove_cv_t<T>> {\n };\ndiff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex 2b66ab978f81..5feaaa965cc5 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -165,6 +165,12 @@ void ControlSerializer::store(const ControlValue &value,\n \t\tbreak;\n \t}\n \n+\tcase ControlTypeFloat: {\n+\t\tfloat data = value.get<float>();\n+\t\tbuffer.write(&data);\n+\t\tbreak;\n+\t}\n+\n \tdefault:\n \t\tbreak;\n \t}\n@@ -337,6 +343,12 @@ ControlValue ControlSerializer::load<ControlValue>(ControlType type,\n \t\treturn ControlValue(value);\n \t}\n \n+\tcase ControlTypeFloat: {\n+\t\tfloat value;\n+\t\tb.read(&value);\n+\t\treturn ControlValue(value);\n+\t}\n+\n \tdefault:\n \t\treturn ControlValue();\n \t}\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 829eea6f4240..46469dd8b98b 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -55,6 +55,7 @@ static constexpr size_t ControlValueSize[] = {\n \t[ControlTypeBool]\t\t= sizeof(bool),\n \t[ControlTypeInteger32]\t\t= sizeof(int32_t),\n \t[ControlTypeInteger64]\t\t= sizeof(int64_t),\n+\t[ControlTypeFloat]\t\t= sizeof(float),\n };\n \n } /* namespace */\n@@ -70,6 +71,8 @@ static constexpr size_t ControlValueSize[] = {\n * The control stores a 32-bit integer value\n * \\var ControlTypeInteger64\n * The control stores a 64-bit integer value\n+ * \\var ControlTypeFloat\n+ * The control stores a 32-bit floating point value\n */\n \n /**\n@@ -209,6 +212,11 @@ std::string ControlValue::toString() const\n \t\t\tstr += std::to_string(*value);\n \t\t\tbreak;\n \t\t}\n+\t\tcase ControlTypeFloat: {\n+\t\t\tconst float *value = reinterpret_cast<const float *>(data);\n+\t\t\tstr += std::to_string(*value);\n+\t\t\tbreak;\n+\t\t}\n \t\tcase ControlTypeNone:\n \t\t\tbreak;\n \t\t}\n@@ -378,9 +386,9 @@ void ControlValue::set(ControlType type, bool isArray, const void *data,\n * instead of Control.\n *\n * Controls of any type can be defined through template specialisation, but\n- * libcamera only supports the bool, int32_t and int64_t types natively (this\n- * includes types that are equivalent to the supported types, such as int and\n- * long int).\n+ * libcamera only supports the bool, int32_t, int64_t and float types natively\n+ * (this includes types that are equivalent to the supported types, such as int\n+ * and long int).\n *\n * Controls IDs shall be unique. While nothing prevents multiple instances of\n * the Control class to be created with the same ID for the same object, doing\n", "prefixes": [ "libcamera-devel", "19/31" ] }