Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2900,
    "url": "https://patchwork.libcamera.org/api/patches/2900/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/2900/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200227200407.490616-19-nicolas.dufresne@collabora.com>",
    "date": "2020-02-27T20:03:58",
    "name": "[libcamera-devel,v2,18/27] gst: libcamerapad: Allow storing a pool",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "a02b25f6555b01c3265b69482d295f82edd7a9d5",
    "submitter": {
        "id": 31,
        "url": "https://patchwork.libcamera.org/api/people/31/?format=api",
        "name": "Nicolas Dufresne",
        "email": "nicolas.dufresne@collabora.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/2900/mbox/",
    "series": [
        {
            "id": 693,
            "url": "https://patchwork.libcamera.org/api/series/693/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=693",
            "date": "2020-02-27T20:03:40",
            "name": "GStreamer Element for libcamera",
            "version": 2,
            "mbox": "https://patchwork.libcamera.org/series/693/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/2900/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/2900/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<nicolas.dufresne@collabora.com>",
        "Received": [
            "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BD4A6274B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Feb 2020 21:04:26 +0100 (CET)",
            "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 016FD2949DF"
        ],
        "From": "Nicolas Dufresne <nicolas.dufresne@collabora.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Thu, 27 Feb 2020 15:03:58 -0500",
        "Message-Id": "<20200227200407.490616-19-nicolas.dufresne@collabora.com>",
        "X-Mailer": "git-send-email 2.24.1",
        "In-Reply-To": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>",
        "References": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v2 18/27] gst: libcamerapad: Allow storing\n\ta pool",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Thu, 27 Feb 2020 20:04:28 -0000"
    },
    "content": "This adds get/set helper to store a pool on the pad.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 18 ++++++++++++++++++\n src/gstreamer/gstlibcamerapad.h   |  6 ++++++\n 2 files changed, 24 insertions(+)",
    "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex d4f5b15..c4c466d 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -16,6 +16,7 @@ using namespace libcamera;\n struct _GstLibcameraPad {\n \tGstPad parent;\n \tStreamRole role;\n+\tGstLibcameraPool *pool;\n };\n \n enum {\n@@ -107,3 +108,20 @@ gst_libcamera_pad_get_role(GstPad *pad)\n \tGLibLocker lock(GST_OBJECT(self));\n \treturn self->role;\n }\n+\n+GstLibcameraPool *\n+gst_libcamera_pad_get_pool(GstPad *pad)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\treturn self->pool;\n+}\n+\n+void\n+gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\n+\tif (self->pool)\n+\t\tg_object_unref(self->pool);\n+\tself->pool = pool;\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 3dea0e7..4570c0c 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -9,6 +9,8 @@\n #include <gst/gst.h>\n #include <libcamera/stream.h>\n \n+#include \"gstlibcamerapool.h\"\n+\n #ifndef __GST_LIBCAMERA_PAD_H__\n #define __GST_LIBCAMERA_PAD_H__\n \n@@ -18,4 +20,8 @@ G_DECLARE_FINAL_TYPE(GstLibcameraPad, gst_libcamera_pad,\n \n libcamera::StreamRole gst_libcamera_pad_get_role(GstPad *pad);\n \n+GstLibcameraPool *gst_libcamera_pad_get_pool(GstPad *pad);\n+\n+void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);\n+\n #endif /* __GST_LIBCAMERA_PAD_H__ */\n",
    "prefixes": [
        "libcamera-devel",
        "v2",
        "18/27"
    ]
}