Patch Detail
Show a patch.
GET /api/patches/2893/?format=api
{ "id": 2893, "url": "https://patchwork.libcamera.org/api/patches/2893/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2893/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200227200407.490616-12-nicolas.dufresne@collabora.com>", "date": "2020-02-27T20:03:51", "name": "[libcamera-devel,v2,11/27] gst: libcamerapad: Add a method to access the role", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b82b47529687bcd9bdde6fd03c0cbf26137e52df", "submitter": { "id": 31, "url": "https://patchwork.libcamera.org/api/people/31/?format=api", "name": "Nicolas Dufresne", "email": "nicolas.dufresne@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2893/mbox/", "series": [ { "id": 693, "url": "https://patchwork.libcamera.org/api/series/693/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=693", "date": "2020-02-27T20:03:40", "name": "GStreamer Element for libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/693/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2893/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2893/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas.dufresne@collabora.com>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 110B0626FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Feb 2020 21:04:23 +0100 (CET)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 7E6EA29654B" ], "From": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Feb 2020 15:03:51 -0500", "Message-Id": "<20200227200407.490616-12-nicolas.dufresne@collabora.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>", "References": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 11/27] gst: libcamerapad: Add a method\n\tto access the role", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 27 Feb 2020 20:04:23 -0000" }, "content": "Each pad can have a different roles. Users will have to request and configure\ntheir pads roles before moving higher state.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 8 ++++++++\n src/gstreamer/gstlibcamerapad.h | 2 ++\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 6212c3b..d4f5b15 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -99,3 +99,11 @@ gst_libcamera_pad_class_init(GstLibcameraPadClass *klass)\n \t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n \tg_object_class_install_property(object_class, PROP_STREAM_ROLE, spec);\n }\n+\n+StreamRole\n+gst_libcamera_pad_get_role(GstPad *pad)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGLibLocker lock(GST_OBJECT(self));\n+\treturn self->role;\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 2e745f1..3dea0e7 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -7,6 +7,7 @@\n */\n \n #include <gst/gst.h>\n+#include <libcamera/stream.h>\n \n #ifndef __GST_LIBCAMERA_PAD_H__\n #define __GST_LIBCAMERA_PAD_H__\n@@ -15,5 +16,6 @@\n G_DECLARE_FINAL_TYPE(GstLibcameraPad, gst_libcamera_pad,\n \t\t GST_LIBCAMERA, PAD, GstPad)\n \n+libcamera::StreamRole gst_libcamera_pad_get_role(GstPad *pad);\n \n #endif /* __GST_LIBCAMERA_PAD_H__ */\n", "prefixes": [ "libcamera-devel", "v2", "11/27" ] }