Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2886,
    "url": "https://patchwork.libcamera.org/api/patches/2886/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/2886/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200227200407.490616-5-nicolas.dufresne@collabora.com>",
    "date": "2020-02-27T20:03:44",
    "name": "[libcamera-devel,v2,04/27] gst: utils: Add simple scoped lockers for GMutex and GRectMutex",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "d02b1c033f75498b2bfba89dd7f62f1059cf327b",
    "submitter": {
        "id": 31,
        "url": "https://patchwork.libcamera.org/api/people/31/?format=api",
        "name": "Nicolas Dufresne",
        "email": "nicolas.dufresne@collabora.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/2886/mbox/",
    "series": [
        {
            "id": 693,
            "url": "https://patchwork.libcamera.org/api/series/693/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=693",
            "date": "2020-02-27T20:03:40",
            "name": "GStreamer Element for libcamera",
            "version": 2,
            "mbox": "https://patchwork.libcamera.org/series/693/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/2886/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/2886/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<nicolas.dufresne@collabora.com>",
        "Received": [
            "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B845762708\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Feb 2020 21:04:19 +0100 (CET)",
            "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 3A1342949DF"
        ],
        "From": "Nicolas Dufresne <nicolas.dufresne@collabora.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Thu, 27 Feb 2020 15:03:44 -0500",
        "Message-Id": "<20200227200407.490616-5-nicolas.dufresne@collabora.com>",
        "X-Mailer": "git-send-email 2.24.1",
        "In-Reply-To": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>",
        "References": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v2 04/27] gst: utils: Add simple scoped\n\tlockers for GMutex and GRectMutex",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Thu, 27 Feb 2020 20:04:21 -0000"
    },
    "content": "While GLib has locker implementation already using g_autoptr(), recursive mutext\nlocker was onmly introduced in recent GLib. Implement a simple locker for GMutex\nand GRectMutex in order to allow making locking simplier and safer.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamera-utils.h | 51 ++++++++++++++++++++++++++++++\n 1 file changed, 51 insertions(+)",
    "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 33160b8..737ca63 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -15,4 +15,55 @@\n \n GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n \n+/**\n+ * \\class GLibLocker\n+ * \\brief A simple scoped mutex locker for GMutex\n+ */\n+class GLibLocker\n+{\n+public:\n+\tGLibLocker(GMutex *mutex)\n+\t\t: mutex_(mutex)\n+\t{\n+\t\tg_mutex_lock(mutex_);\n+\t}\n+\n+\tGLibLocker(GstObject *object)\n+\t\t: mutex_(GST_OBJECT_GET_LOCK(object))\n+\t{\n+\t\tg_mutex_lock(mutex_);\n+\t}\n+\n+\t~GLibLocker()\n+\t{\n+\t\tg_mutex_unlock(mutex_);\n+\t}\n+\n+private:\n+\tGMutex *mutex_;\n+};\n+\n+/**\n+ * \\class GLibRecLocker\n+ * \\brief A simple scoped mutex locker for GRecMutex\n+ */\n+class GLibRecLocker\n+{\n+public:\n+\tGLibRecLocker(GRecMutex *mutex)\n+\t\t: mutex_(mutex)\n+\t{\n+\t\tg_rec_mutex_lock(mutex_);\n+\t}\n+\n+\t~GLibRecLocker()\n+\t{\n+\t\tg_rec_mutex_unlock(mutex_);\n+\t}\n+\n+private:\n+\tGRecMutex *mutex_;\n+};\n+\n+\n #endif /* __GST_LIBCAMERA_UTILS_H_ */\n",
    "prefixes": [
        "libcamera-devel",
        "v2",
        "04/27"
    ]
}