Patch Detail
Show a patch.
GET /api/patches/287/?format=api
{ "id": 287, "url": "https://patchwork.libcamera.org/api/patches/287/?format=api", "web_url": "https://patchwork.libcamera.org/patch/287/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190121092020.4145-1-jacopo@jmondi.org>", "date": "2019-01-21T09:20:20", "name": "[libcamera-devel] libcamera: v4l2_device: Return const std::string", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "ef25a939f6ad45a5b5a37104a2169ee6b357a65b", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/287/mbox/", "series": [ { "id": 97, "url": "https://patchwork.libcamera.org/api/series/97/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=97", "date": "2019-01-21T09:20:20", "name": "[libcamera-devel] libcamera: v4l2_device: Return const std::string", "version": 1, "mbox": "https://patchwork.libcamera.org/series/97/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/287/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/287/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 165B160C65\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jan 2019 10:20:17 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 991C820001F;\n\tMon, 21 Jan 2019 09:20:15 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 21 Jan 2019 10:20:20 +0100", "Message-Id": "<20190121092020.4145-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: v4l2_device: Return const\n\tstd::string", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 21 Jan 2019 09:20:17 -0000" }, "content": "Make getter functions of V4L2Device return std::string as the rest of\nthe library does.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/include/v4l2_device.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n--\n2.20.1", "diff": "diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\nindex 474c05b..5fe3d82 100644\n--- a/src/libcamera/include/v4l2_device.h\n+++ b/src/libcamera/include/v4l2_device.h\n@@ -45,9 +45,9 @@ public:\n \tbool isOpen() const;\n \tvoid close();\n\n-\tconst char *driverName() const { return caps_.driver(); }\n-\tconst char *deviceName() const { return caps_.card(); }\n-\tconst char *busName() const { return caps_.bus_info(); }\n+\tconst std::string driverName() const { return std::string(caps_.driver()); }\n+\tconst std::string deviceName() const { return std::string(caps_.card()); }\n+\tconst std::string busName() const { return std::string(caps_.bus_info()); }\n\n private:\n \tstd::string devnode_;\n", "prefixes": [ "libcamera-devel" ] }