Patch Detail
Show a patch.
GET /api/patches/2845/?format=api
{ "id": 2845, "url": "https://patchwork.libcamera.org/api/patches/2845/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2845/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200217153941.20713-1-kieran.bingham@ideasonboard.com>", "date": "2020-02-17T15:39:41", "name": "[libcamera-devel] qcam: Use standard PicturesLocation path for capture", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d95e7c3c75f3f108a2e60f566502922e88e876f3", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2845/mbox/", "series": [ { "id": 681, "url": "https://patchwork.libcamera.org/api/series/681/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=681", "date": "2020-02-17T15:39:41", "name": "[libcamera-devel] qcam: Use standard PicturesLocation path for capture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/681/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2845/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2845/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C373561944\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2020 16:39:45 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DB3652A;\n\tMon, 17 Feb 2020 16:39:45 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581953985;\n\tbh=ytruXH/aGXRibJkxcNVdfFD28saAfFBNwvg4QL7AjFc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=tkuPp18Qpih0lwnaCz5ZLN0XM6U/xOTeaXTE6QxR+QHR32eUiUrRras7xXNri7rYq\n\tAJCPVafpflhbrKYbW0dthcK9bgVVluhr7A+BtxFNTaPaxHQNSqMsdhIb1x7GYESPJM\n\tjySh4eW4cl6+LJp+aonxIyNYFKzO1xM8yCBXUY+4=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 17 Feb 2020 15:39:41 +0000", "Message-Id": "<20200217153941.20713-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] qcam: Use standard PicturesLocation path\n\tfor capture", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 17 Feb 2020 15:39:46 -0000" }, "content": "Utilise the QStandardPaths::PicturesLocation as a starting point for\nsaving images from qcam.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 29eaba8454f8..09e4bfc11300 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -17,6 +17,7 @@\n #include <QImage>\n #include <QImageWriter>\n #include <QInputDialog>\n+#include <QStandardPaths>\n #include <QTimer>\n #include <QToolBar>\n #include <QToolButton>\n@@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n void MainWindow::saveImageAs()\n {\n \tQImage image = viewfinder_->getCurrentImage();\n+\tQString defaultPath = QStandardPaths::standardLocations(QStandardPaths::PicturesLocation).last();\n \n-\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n+\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n \n \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n", "prefixes": [ "libcamera-devel" ] }