Patch Detail
Show a patch.
GET /api/patches/2809/?format=api
{ "id": 2809, "url": "https://patchwork.libcamera.org/api/patches/2809/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2809/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200213130908.23638-2-kieran.bingham@ideasonboard.com>", "date": "2020-02-13T13:09:06", "name": "[libcamera-devel,1/3] libcamera: utils: Add string splitter utility function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6c837309ddcb73c234f5b5f713351c9f812885cc", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2809/mbox/", "series": [ { "id": 670, "url": "https://patchwork.libcamera.org/api/series/670/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=670", "date": "2020-02-13T13:09:05", "name": "utils: Provide string splitting", "version": 1, "mbox": "https://patchwork.libcamera.org/series/670/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2809/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2809/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E97B61958\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Feb 2020 14:09:13 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E4B9ACB;\n\tThu, 13 Feb 2020 14:09:12 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581599352;\n\tbh=+AsYR35NBAexmEXP8d1OOkRLLfRkqNq0g5qcmVuwKco=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZSHRGiX8uSEk54CPuanUlG4zfF8lcVGKNKC9jG6TAQ+iUMsJXXa1HyGIJAp5nDdgj\n\t2t6Hk2NbF0K51+/aUpMV8omI1VP9QB0YdaYxUzPMAhJwqVKl4qsyeDOEF8zP0SjMlF\n\taeaeZu+4MbFjk9Wng6U9WxsJSeuFJYd7wy5OmKHw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 13 Feb 2020 13:09:06 +0000", "Message-Id": "<20200213130908.23638-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200213130908.23638-1-kieran.bingham@ideasonboard.com>", "References": "<20200213130908.23638-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: utils: Add string splitter\n\tutility function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 13 Feb 2020 13:09:13 -0000" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nAdd a utils::split() function that splits a string for the purpose of\niterating over substrings. It returns an object of unspecified type that\ncan be used in range-based for loops.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/Doxyfile.in | 1 +\n src/libcamera/include/utils.h | 34 +++++++++++++++++++\n src/libcamera/utils.cpp | 62 +++++++++++++++++++++++++++++++++++\n 3 files changed, 97 insertions(+)", "diff": "diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\nindex 1c46b04b3f7e..beeaf6d3cf48 100644\n--- a/Documentation/Doxyfile.in\n+++ b/Documentation/Doxyfile.in\n@@ -880,6 +880,7 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n libcamera::BoundMethodStatic \\\n libcamera::SignalBase \\\n libcamera::*::Private \\\n+ libcamera::*::details::* \\\n std::*\n \n # The EXAMPLE_PATH tag can be used to specify one or more files or directories\ndiff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\nindex e467eb21c518..080ea6614de0 100644\n--- a/src/libcamera/include/utils.h\n+++ b/src/libcamera/include/utils.h\n@@ -108,6 +108,40 @@ inline _hex hex<uint64_t>(uint64_t value, unsigned int width)\n \n size_t strlcpy(char *dst, const char *src, size_t size);\n \n+namespace details {\n+\n+class StringSplitter\n+{\n+public:\n+\tStringSplitter(const std::string &str, const std::string &delim);\n+\n+\tclass iterator\n+\t{\n+\tpublic:\n+\t\titerator(const StringSplitter *ss, std::string::size_type pos);\n+\n+\t\titerator &operator++();\n+\t\tstd::string operator*() const;\n+\t\tbool operator!=(const iterator &other) const;\n+\n+\tprivate:\n+\t\tconst StringSplitter *ss_;\n+\t\tstd::string::size_type pos_;\n+\t\tstd::string::size_type next_;\n+\t};\n+\n+\titerator begin() const;\n+\titerator end() const;\n+\n+private:\n+\tstd::string str_;\n+\tstd::string delim_;\n+};\n+\n+} /* namespace details */\n+\n+details::StringSplitter split(const std::string &str, const std::string &delim);\n+\n } /* namespace utils */\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex 4beffdab5eb6..fe027c0b009c 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -199,6 +199,68 @@ size_t strlcpy(char *dst, const char *src, size_t size)\n \treturn strlen(src);\n }\n \n+details::StringSplitter::StringSplitter(const std::string &str, const std::string &delim)\n+\t: str_(str), delim_(delim)\n+{\n+}\n+\n+details::StringSplitter::iterator::iterator(const details::StringSplitter *ss, std::string::size_type pos)\n+\t: ss_(ss), pos_(pos)\n+{\n+\tnext_ = ss_->str_.find(ss_->delim_, pos_);\n+}\n+\n+details::StringSplitter::iterator &details::StringSplitter::iterator::operator++()\n+{\n+\tpos_ = next_;\n+\tif (pos_ != std::string::npos) {\n+\t\tpos_ += ss_->delim_.length();\n+\t\tnext_ = ss_->str_.find(ss_->delim_, pos_);\n+\t}\n+\n+\treturn *this;\n+}\n+\n+std::string details::StringSplitter::iterator::operator*() const\n+{\n+\tstd::string::size_type count;\n+\tcount = next_ != std::string::npos ? next_ - pos_ : next_;\n+\treturn ss_->str_.substr(pos_, count);\n+}\n+\n+bool details::StringSplitter::iterator::operator!=(const details::StringSplitter::iterator &other) const\n+{\n+\treturn pos_ != other.pos_;\n+}\n+\n+details::StringSplitter::iterator details::StringSplitter::begin() const\n+{\n+\treturn iterator(this, 0);\n+}\n+\n+details::StringSplitter::iterator details::StringSplitter::end() const\n+{\n+\treturn iterator(this, std::string::npos);\n+}\n+\n+/**\n+ * \\fn split(const std::string &str, const std::string &delim)\n+ * \\brief Split a string based on a delimiter\n+ * \\param[in] str The string to split\n+ * \\param[in] delim The delimiter string\n+ *\n+ * This function splits the string \\a str into substrings based on the\n+ * delimiter \\a delim. It returns an object of unspecified type that can be\n+ * used in a range-based for loop and yields the substrings in sequence.\n+ *\n+ * \\return An object that can be used in a range-based for loop to iterate over\n+ * the substrings\n+ */\n+details::StringSplitter split(const std::string &str, const std::string &delim)\n+{\n+\treturn details::StringSplitter(str, delim);\n+}\n+\n } /* namespace utils */\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "1/3" ] }