Patch Detail
Show a patch.
GET /api/patches/2804/?format=api
{ "id": 2804, "url": "https://patchwork.libcamera.org/api/patches/2804/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2804/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>", "date": "2020-02-12T23:54:51", "name": "[libcamera-devel] meson.build: Silence the C99 designators warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5241feb7fb2a281752a2900ea5e44e746bb82a55", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2804/mbox/", "series": [ { "id": 668, "url": "https://patchwork.libcamera.org/api/series/668/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=668", "date": "2020-02-12T23:54:51", "name": "[libcamera-devel] meson.build: Silence the C99 designators warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/668/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2804/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2804/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 946D160F3C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Feb 2020 00:55:12 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92E37504\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Feb 2020 00:55:11 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581551712;\n\tbh=taE6Pv6zX4oKEIjql4fNfYSrzoy5TjDN2/bgSS7CvIw=;\n\th=From:To:Subject:Date:From;\n\tb=rv2RxMUavMzTRGzZ7V1kjNEtsFBhccGdhgmv1J9Og6XsBZRv+qNnIHC3SYZGSMIS9\n\tIWz6tJ6nsgA8/sSRyNyWDxW/Cc1JY32+IOVXTK8P+L5nJ9RiGata4e9BdvHZwY3GH3\n\tOUDgtZVGeTcC4RbigjjAWUHb/mvOX4efxLUhV7Ek=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 13 Feb 2020 01:54:51 +0200", "Message-Id": "<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] meson.build: Silence the C99 designators\n\twarning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 12 Feb 2020 23:55:12 -0000" }, "content": "We use array designators for array initialization, which is a C99\nextension. clang-10 warns about it, causing a build failure.\n\nAs this is a useful extension, silence the warning. This needs to be\ndone only if the compiler supports the -Wno-c99-designator argument,\notherwise a -Wunknown-warning-option will be generated.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/meson.build b/meson.build\nindex 0bbd24b2a295..aceba997aebd 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -60,6 +60,12 @@ if cc.get_id() == 'clang'\n endif\n endif\n \n+if cc.has_argument('-Wno-c99-designator')\n+ common_arguments += [\n+ '-Wno-c99-designator',\n+ ]\n+endif\n+\n c_arguments += common_arguments\n cpp_arguments += common_arguments\n \n", "prefixes": [ "libcamera-devel" ] }