Patch Detail
Show a patch.
GET /api/patches/2788/?format=api
{ "id": 2788, "url": "https://patchwork.libcamera.org/api/patches/2788/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2788/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200206150504.24204-3-kieran.bingham@ideasonboard.com>", "date": "2020-02-06T15:05:00", "name": "[libcamera-devel,2/6] qcam: Expose quit method for MainWindow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a08e86f359bd7a74ab2833e377f32313dd108ca2", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2788/mbox/", "series": [ { "id": 663, "url": "https://patchwork.libcamera.org/api/series/663/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=663", "date": "2020-02-06T15:04:58", "name": "qcam: Provide an initial toolbar", "version": 1, "mbox": "https://patchwork.libcamera.org/series/663/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2788/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2788/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A52E600FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 6 Feb 2020 16:05:10 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 234F01227;\n\tThu, 6 Feb 2020 16:05:10 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581001510;\n\tbh=EK7IMDyzHjDuX4N6XYWlzj+eItFvFg/2ZwLUsobG3Dw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lu4b6BjRAQW96rGxPzczx0PkbsgAJn4qXpmCUhcXQM726xnfD/3pyQ2oh8C83Ozx4\n\tOcdULQKQzllKUPCE8fxwSwoba7sWr6PihMmaS4SloKLZqT3UB6WCnLu4JW+q4uw9Un\n\taojiD5BQSbnLaXhaj2dd2/H84Y1Qz2irovK0i1A8=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 6 Feb 2020 15:05:00 +0000", "Message-Id": "<20200206150504.24204-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200206150504.24204-1-kieran.bingham@ideasonboard.com>", "References": "<20200206150504.24204-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/6] qcam: Expose quit method for\n\tMainWindow", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 06 Feb 2020 15:05:10 -0000" }, "content": "Provide a method to facilitate clean shutdowns.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 9 +++++++--\n src/qcam/main_window.h | 1 +\n 2 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 38bc04a23b86..b51a16de199d 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -41,8 +41,7 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n \t}\n \n \tif (ret < 0)\n-\t\tQTimer::singleShot(0, QCoreApplication::instance(),\n-\t\t\t\t &QCoreApplication::quit);\n+\t\tquit();\n }\n \n MainWindow::~MainWindow()\n@@ -54,6 +53,12 @@ MainWindow::~MainWindow()\n \t}\n }\n \n+void MainWindow::quit()\n+{\n+\tQTimer::singleShot(0, QCoreApplication::instance(),\n+\t\t\t &QCoreApplication::quit);\n+}\n+\n void MainWindow::updateTitle()\n {\n \tunsigned int duration = frameRateInterval_.elapsed();\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 04fb9e3ea869..a11443b30b37 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -41,6 +41,7 @@ public:\n \t~MainWindow();\n \n private Q_SLOTS:\n+\tvoid quit();\n \tvoid updateTitle();\n \n private:\n", "prefixes": [ "libcamera-devel", "2/6" ] }