Patch Detail
Show a patch.
GET /api/patches/27634/?format=api
{ "id": 27634, "url": "https://patchwork.libcamera.org/api/patches/27634/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27634/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260805-libipa-algorithms-v7-11-7425b5b795d4@ideasonboard.com>", "date": "2026-08-05T16:12:53", "name": "[v7,11/32] ipa: libipa: lsc_polynomial: Fix polynomial parsing error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ea3fe6daf01db745db5a4b35986ba7698397b649", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27634/mbox/", "series": [ { "id": 6110, "url": "https://patchwork.libcamera.org/api/series/6110/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6110", "date": "2026-08-05T16:12:42", "name": "ipa: libipa: Introduce libipa algorithms", "version": 7, "mbox": "https://patchwork.libcamera.org/series/6110/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27634/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27634/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77341C330F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Aug 2026 16:13:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1DA06816C;\n\tWed, 5 Aug 2026 18:13:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9AF968140\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Aug 2026 18:13:31 +0200 (CEST)", "from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it\n\t[109.113.25.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0046839A0;\n\tWed, 5 Aug 2026 18:12:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UlOaQ1oY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785946341;\n\tbh=iym+xPwKbdXJhKWKBEgCczMlRqIVu/lwQ9sWa5xwMiM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=UlOaQ1oYWazbCrizmAoUiSXBaSwjJJsPRfZTQhPUAzBeoR99bIhTaUdEIqUXTEPQz\n\tXcWQ/iEpfgk2nV84NXJtTRuJnxs8sWQHZ+RPr4ZCNe4+kxytpJirCwLiuBC3L7Er3i\n\t+baEPvFWdAwx+FpsDBC8bV41JeAVDcPPjWgvXxWQ=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 05 Aug 2026 18:12:53 +0200", "Subject": "[PATCH v7 11/32] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260805-libipa-algorithms-v7-11-7425b5b795d4@ideasonboard.com>", "References": "<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>", "In-Reply-To": "<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>, \n\tMilan Zamazal <mzamazal@redhat.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1449;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=iym+xPwKbdXJhKWKBEgCczMlRqIVu/lwQ9sWa5xwMiM=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2EcIX3th44+oDmMbMzn72qRttNqiI8Jw/LmC\n\taCDgG+BgtmJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhHAAKCRByNAaPFqFW\n\tPGzoD/4v9eH91AgjtePUpdshgWKRygK/q/zV2QIeADuN3GJK/0lS3xHqZFRwfuDOzROLez9FRKp\n\tVGrd162m1Pui/f1VNASBGux+4e2CI8eKmHTk6kS5WFp9kNlja4SOWONn6R81QVGsn5ghVxW+NhZ\n\tbMycYcLiIQCe4edrCc/6VITMDeu1NwP4aX5Xuq5+x045BnZOlyl0+CWW+to0JQCJ65UTSjj2tni\n\tui570HwfvxLs/Qvjw49aYcbVAs5W/Iixq5jivEEa7e0X7xZtPpQ6RpFbmhKCGN5+Wa03WZYFw6a\n\t+A/4FxkxXjxLTFN4Bq1pTaTlo6EmhwhTHnVAv0nnTukFGO8GfI3ZuwSr7t7Oeiux2H8WQW8M1MQ\n\tGzE/AndDHipM3c0reUkRNqcPAEAK45HP77JAY5uFlnZw4p9qTUC8wdCDL3UrEIvIygYPQV901TA\n\t9Vlrelv8CZuW/G8qNDaXdLUmMecegKmqMVQSxMa8c4uiImr2ck9smXtuqs5V3h7ZvQLuni8EurG\n\tdO1IuW2tt5Yp8BShaBFIKr/CSL2camkdGN2PCNe7hPne1qpn698/f5luUjpPXud7JzO5QqcX3bx\n\t4ocDGAM1BrJ6TR+JaLYKEJyjCfNi1GWnfk0KHWh4MCWfjeAaeNQPtvh3fLPuqi3xvlGFND4YbDc\n\t9tEqMkVpY7l51aw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If any of the polynomial component is missing in the tuning file the\nValueNode::Accessor<ipa::LscPolynomial> specialization emits an\nerror message but continues and dereferences a potentially\ninvalid object.\n\nFix it by returning std::nullopt if a polynomial component is missing.\n\nThe caller already checks if the returned value is valid or not, causing\nthe algorithm initialization to fail if the tuning file is invalid.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/libipa/lsc_polynomial.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex d7d9ae42e360..a0d27c4b21d6 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -94,9 +94,11 @@ struct ValueNode::Accessor<ipa::LscPolynomial> {\n \t\tstd::optional<double> k3 = obj[\"k3\"].get<double>();\n \t\tstd::optional<double> k4 = obj[\"k4\"].get<double>();\n \n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n+\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n \t\t\tLOG(LscPolynomial, Error)\n \t\t\t\t<< \"Polynomial is missing a parameter\";\n+\t\t\treturn std::nullopt;\n+\t\t}\n \n \t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n \t}\n", "prefixes": [ "v7", "11/32" ] }