Patch Detail
Show a patch.
GET /api/patches/2762/?format=api
{ "id": 2762, "url": "https://patchwork.libcamera.org/api/patches/2762/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2762/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200131095245.25906-1-naush@raspberrypi.com>", "date": "2020-01-31T09:52:45", "name": "[libcamera-devel] QCam: Swich default stream role to viewfinder.", "commit_ref": "8ce24bebbf177136b1a5640287239644e98c4b52", "pull_url": null, "state": "accepted", "archived": false, "hash": "ba5edc52cba5a8026adf741eeb1e94f24c40eb11", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2762/mbox/", "series": [ { "id": 653, "url": "https://patchwork.libcamera.org/api/series/653/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=653", "date": "2020-01-31T09:52:45", "name": "[libcamera-devel] QCam: Swich default stream role to viewfinder.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/653/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2762/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2762/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wr1-x444.google.com (mail-wr1-x444.google.com\n\t[IPv6:2a00:1450:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAA5B608D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jan 2020 10:55:00 +0100 (CET)", "by mail-wr1-x444.google.com with SMTP id b6so7908310wrq.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jan 2020 01:55:00 -0800 (PST)", "from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\ty131sm10704335wmc.13.2020.01.31.01.54.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 31 Jan 2020 01:54:59 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=V1p7Lq4opgBPRQ+ZO2nnJJXMFWWuHwtv7jcw0/7hcyQ=;\n\tb=eo/KEEpRuNzAUYS1v1Ug4DlRyh0Iq1CI3ITZxlhNWV8dGWkOaeKYpOgEwKIWkEPVlK\n\tnJZycumV2MtYloAR0E6NutKbKC5WvyR+hBTCTZVi6cFe4BMou7hVRe6UvIdFga7a4v4y\n\t8utq5wocW6hRaPjShGum8Y3fcy1or1ZJ46c/i47Ws28AF94Vjk688Tr2pAnLRH7/8JBa\n\tyXGDrX90DYHihY07MKgAsWO6qcH6U2tt4HU0lqlATrpwwBSchOoAKs5q/q1o+HS7WM/I\n\teVvxhZiNSi0ZUUXRNtciezsUN3JHaRyFtB3aikxO/NeJhgpKNuNuE/cumyUvl/fQYt1M\n\tBbOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=V1p7Lq4opgBPRQ+ZO2nnJJXMFWWuHwtv7jcw0/7hcyQ=;\n\tb=pkpqWs0utKu5Kp4v54Mr7sy9ju61uuzELoLPE8wEa8J88HZJNsO3KtNBozb8e2zgKW\n\tLA20/MC6wKd7R9H/OfLW/Cak835LDaG9pfk/vD2Y8vhmjwpoAV4ZQKyggwvEA8ljmcLb\n\tGiGro+n/g9VnuIt/52LZdZybJg0esSC91zYhrny2GG1lytMm4QcvxQwzSYDu6AFp3gt2\n\tRlIFg9CKHtLcbZThJvN7tXGSCj8F+0qgxATmrFcAPduesYwvocBdGg+BWF2nDaDzDWpL\n\tW3+aWhH9kvkeCByP56BEfq0fI0WrDvQGHYgwrAzhFzppwWwHVyL/j9pAp7BU4eKisLN7\n\tkOIQ==", "X-Gm-Message-State": "APjAAAVba9qPHAJSrXNRKq3SDqMru44fWNyCSeSl5LHwA7mAPGYzj1TJ\n\tWql79wuq708/4mBEnh1AM9XssRCJE4jjfw==", "X-Google-Smtp-Source": "APXvYqyMAEmb6a5ydYx3cowwTZDpsIAFumwPtM6noBug8znk3cw7GQ6STdmMeD8nhEW5RD1ZSzlf0w==", "X-Received": "by 2002:a5d:6445:: with SMTP id d5mr9687557wrw.244.1580464500350;\n\tFri, 31 Jan 2020 01:55:00 -0800 (PST)", "From": "naush@raspberrypi.com", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 31 Jan 2020 09:52:45 +0000", "Message-Id": "<20200131095245.25906-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[libcamera-devel] [PATCH] QCam: Swich default stream role to\n\tviewfinder.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 31 Jan 2020 09:55:01 -0000" }, "content": "From: Naushir Patuck <naush@raspberrypi.com>\n\nQCam currently only displays a standard viewfinder. As such set the\nStreamRole parameter to Viewfinder so that the pipeline handlers can\nsetup the appropriate resolutions and formats.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/qcam/main_window.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex df51fa8..70a3e61 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -125,7 +125,7 @@ int MainWindow::startCapture()\n {\n \tint ret;\n \n-\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n+\tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n \n \tStreamConfiguration &cfg = config_->at(0);\n \tif (options_.isSet(OptSize)) {\n", "prefixes": [ "libcamera-devel" ] }