Patch Detail
Show a patch.
GET /api/patches/27606/?format=api
{ "id": 27606, "url": "https://patchwork.libcamera.org/api/patches/27606/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27606/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260804101949.353266-5-barnabas.pocze@ideasonboard.com>", "date": "2026-08-04T10:19:43", "name": "[RFC,v1,04/10] libcamera: egl: Ensure all members are always initialized", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bd9af4d4d7a0d49b9383441f6373d251a2df1cc5", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27606/mbox/", "series": [ { "id": 6105, "url": "https://patchwork.libcamera.org/api/series/6105/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6105", "date": "2026-08-04T10:19:39", "name": "libcamera: software_isp: debayer_egl: Remove some leaks", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6105/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27606/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27606/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A265C3308\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2026 10:20:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B6F768085;\n\tTue, 4 Aug 2026 12:19:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3958567F9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:19:53 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B21F71C76\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:18:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RK6ZrayC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838723;\n\tbh=DEKD1Mki7mJpqM+ax+zPvZpCyHbeldmZ/Mnao76jE6g=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RK6ZrayC0s3qy5OaEi58dAPquMcMY0H58vt08FgZVE7tad/Kx384kt7mvf4ckycqG\n\tOSOjMkBfkkMm59R+2ZJA/6TCjILjfKVG1JhQTRdDrcE4K8UoQpMAanSiZSuq/AGV5/\n\t571qfdyxSv9jvj6Ofq1n4gDgVWvjS66iL5Xa06fw=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 04/10] libcamera: egl: Ensure all members are always\n\tinitialized", "Date": "Tue, 4 Aug 2026 12:19:43 +0200", "Message-ID": "<20260804101949.353266-5-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "References": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The `tid_` and function pointer members were not previously\ninitialize before calling `initEGLContext()`, fix that.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/egl.h | 10 ++++++----\n src/libcamera/egl.cpp | 24 +++++++++++++-----------\n 2 files changed, 19 insertions(+), 15 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 6abb02bf3b..fb77225ac4 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -129,7 +129,7 @@ public:\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGL)\n \n-\tpid_t tid_;\n+\tpid_t tid_ = -1;\n \n \tEGLDisplay display_ = EGL_NO_DISPLAY;\n \tEGLContext context_ = EGL_NO_CONTEXT;\n@@ -139,8 +139,10 @@ private:\n \n \tint createDMABufTexture2D(eGLImage &eglImage, int fd, bool output);\n \n-\tPFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n-\tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n-\tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n+\tstruct VTable {\n+\t\tPFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n+\t\tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n+\t\tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n+\t} vtable_ = {};\n };\n } //namespace libcamera\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 0768a840e6..3de5fab816 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -199,9 +199,9 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n \t};\n \t// clang-format on\n \n-\tEGLImageKHR image = eglCreateImageKHR(display_, EGL_NO_CONTEXT,\n-\t\t\t\t\t EGL_LINUX_DMA_BUF_EXT,\n-\t\t\t\t\t NULL, image_attrs);\n+\tEGLImageKHR image = vtable_.eglCreateImageKHR(display_, EGL_NO_CONTEXT,\n+\t\t\t\t\t\t EGL_LINUX_DMA_BUF_EXT,\n+\t\t\t\t\t\t NULL, image_attrs);\n \n \tif (image == EGL_NO_IMAGE_KHR) {\n \t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n@@ -212,8 +212,8 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n \tactivateBindTexture(eglImage);\n \n \t// Generate texture with filter semantics\n-\tglEGLImageTargetTexture2DOES(GL_TEXTURE_2D, image);\n-\teglDestroyImageKHR(display_, image);\n+\tvtable_.glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, image);\n+\tvtable_.eglDestroyImageKHR(display_, image);\n \n \t// Nearest filtering\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);\n@@ -379,6 +379,7 @@ int eGL::initEGLContext()\n \t\tEGL_NONE\n \t};\n \n+\tVTable vtable = {};\n \tEGLint numConfigs;\n \tEGLConfig config;\n \n@@ -392,20 +393,20 @@ int eGL::initEGLContext()\n \tLOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);\n \tLOG(eGL, Info) << \"EGL: EGL_EXTENSIONS: \" << eglQueryString(display_, EGL_EXTENSIONS);\n \n-\teglCreateImageKHR = (PFNEGLCREATEIMAGEKHRPROC)eglGetProcAddress(\"eglCreateImageKHR\");\n-\tif (!eglCreateImageKHR) {\n+\tvtable.eglCreateImageKHR = (PFNEGLCREATEIMAGEKHRPROC)eglGetProcAddress(\"eglCreateImageKHR\");\n+\tif (!vtable.eglCreateImageKHR) {\n \t\tLOG(eGL, Error) << \"eglCreateImageKHR not found\";\n \t\tgoto fail;\n \t}\n \n-\teglDestroyImageKHR = (PFNEGLDESTROYIMAGEKHRPROC)eglGetProcAddress(\"eglDestroyImageKHR\");\n-\tif (!eglDestroyImageKHR) {\n+\tvtable.eglDestroyImageKHR = (PFNEGLDESTROYIMAGEKHRPROC)eglGetProcAddress(\"eglDestroyImageKHR\");\n+\tif (!vtable.eglDestroyImageKHR) {\n \t\tLOG(eGL, Error) << \"eglDestroyImageKHR not found\";\n \t\tgoto fail;\n \t}\n \n-\tglEGLImageTargetTexture2DOES = (PFNGLEGLIMAGETARGETTEXTURE2DOESPROC)eglGetProcAddress(\"glEGLImageTargetTexture2DOES\");\n-\tif (!glEGLImageTargetTexture2DOES) {\n+\tvtable.glEGLImageTargetTexture2DOES = (PFNGLEGLIMAGETARGETTEXTURE2DOESPROC)eglGetProcAddress(\"glEGLImageTargetTexture2DOES\");\n+\tif (!vtable.glEGLImageTargetTexture2DOES) {\n \t\tLOG(eGL, Error) << \"glEGLImageTargetTexture2DOES not found\";\n \t\tgoto fail;\n \t}\n@@ -422,6 +423,7 @@ int eGL::initEGLContext()\n \t}\n \n \ttid_ = Thread::currentId();\n+\tvtable_ = vtable;\n \n \tmakeCurrent();\n \n", "prefixes": [ "RFC", "v1", "04/10" ] }