Patch Detail
Show a patch.
GET /api/patches/27603/?format=api
{ "id": 27603, "url": "https://patchwork.libcamera.org/api/patches/27603/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27603/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260804101949.353266-2-barnabas.pocze@ideasonboard.com>", "date": "2026-08-04T10:19:40", "name": "[RFC,v1,01/10] libcamera: egl: Remove `gl{Use, Delete}Program()`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3df0fd7d174a5604019f01448fb03ef1e61f6edd", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27603/mbox/", "series": [ { "id": 6105, "url": "https://patchwork.libcamera.org/api/series/6105/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6105", "date": "2026-08-04T10:19:39", "name": "libcamera: software_isp: debayer_egl: Remove some leaks", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6105/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27603/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27603/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE91CC3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2026 10:19:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D42E6808A;\n\tTue, 4 Aug 2026 12:19:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A0396807C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:19:52 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D69B91CDD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:18:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NtUQA11Q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838722;\n\tbh=7VqqfGmzBTKtmeNiIcMS4kf7Ey5jqn2XzCeznL+segA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NtUQA11Qh52LSI8oAvKhFHhaBQy9XjDbV8wFKGb5fTl2CuCgA+B7CexokLMHjHnIV\n\t+asqy2hsVKGIS6bROdlaOKrgUq0CEU4sX8Zj97Ynq/s65WrFoyTVM7dIKWoy7PLtpc\n\tYugqNG/Fgx4uefMh+/MPNfWuq0dh0+NPc6dc4fuk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 01/10] libcamera: egl: Remove `gl{Use,\n\tDelete}Program()`", "Date": "Tue, 4 Aug 2026 12:19:40 +0200", "Message-ID": "<20260804101949.353266-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "References": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`eGL::deleteProgram()` is currently unused, and the only user of `eGL::useProgram()`\nis `debayer_egl.cpp`, which is already using numerous gl calls directly without\ngoing through the `eGL` type. So remove these trivial wrappers.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/egl.h | 2 --\n src/libcamera/egl.cpp | 28 ----------------------\n src/libcamera/software_isp/debayer_egl.cpp | 2 +-\n 3 files changed, 1 insertion(+), 31 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 7ef1ca0d93..c43684808d 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -123,8 +123,6 @@ public:\n \t\t\t\t Span<const std::string> shaderEnv);\n \tint linkProgram(GLuint &programId, GLuint fragmentshaderId, GLuint vertexshaderId);\n \tvoid dumpShaderSource(GLuint shaderId);\n-\tvoid useProgram(GLuint programId);\n-\tvoid deleteProgram(GLuint programId);\n \tvoid syncOutput();\n \tvoid flushOutput();\n \ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 01e51cda8e..780b7bc2d5 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -464,34 +464,6 @@ void eGL::makeCurrent()\n \t}\n }\n \n-/**\n- * \\brief Activate a shader program for rendering\n- * \\param[in] programId OpenGL program object ID\n- *\n- * Sets the specified program as the current rendering program. All\n- * subsequent draw calls will use this program's shaders.\n- */\n-void eGL::useProgram(GLuint programId)\n-{\n-\tASSERT(tid_ == Thread::currentId());\n-\n-\tglUseProgram(programId);\n-}\n-\n-/**\n- * \\brief Delete a shader program\n- * \\param[in] programId OpenGL program object ID\n- *\n- * Deletes a shader program and frees associated resources. The program\n- * must not be currently in use.\n- */\n-void eGL::deleteProgram(GLuint programId)\n-{\n-\tASSERT(tid_ == Thread::currentId());\n-\n-\tglDeleteProgram(programId);\n-}\n-\n /**\n * \\brief Add a preprocessor definition to shader environment\n * \\param[in,out] shaderEnv Vector of shader environment strings\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 20b478b1c3..ede3be2352 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -261,7 +261,7 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n \tegl_.dumpShaderSource(fragmentShaderId_);\n \n \t/* Ensure we set the programId_ */\n-\tegl_.useProgram(programId_);\n+\tglUseProgram(programId_);\n \terr = glGetError();\n \tif (err != GL_NO_ERROR) {\n \t\tLOG(Debayer, Error) << \"Use program error \" << err;\n", "prefixes": [ "RFC", "v1", "01/10" ] }