Patch Detail
Show a patch.
GET /api/patches/27598/?format=api
{ "id": 27598, "url": "https://patchwork.libcamera.org/api/patches/27598/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27598/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260803131435.153927-50-barnabas.pocze@ideasonboard.com>", "date": "2026-08-03T13:14:34", "name": "[RFC,v3,49/50] libcamera: pipeline: Set vblank on more platforms", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a33fae2c2fa993929886ba92dbb5327739b26424", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27598/mbox/", "series": [ { "id": 6103, "url": "https://patchwork.libcamera.org/api/series/6103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6103", "date": "2026-08-03T13:13:45", "name": "ipa: libipa: agc rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27598/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27598/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 785B7C3350\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2026 13:15:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 771286811E;\n\tMon, 3 Aug 2026 15:15:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF39E68075\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:14:49 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDC51512\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:13:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nz9QHrYe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762820;\n\tbh=UQb6u+AzrJyQBlWloxXjUlpt0xqzbCYGmOJsyP74WEg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Nz9QHrYegXgY0btiinIQ61+hP48KZxZhVAuyHYvAbZftH4C4+6irlCCGkBzNxe8WS\n\tQkE5DmYHqCS9zpgjO5rTI0ogYcsxYTZ0EpccJAou/MTjQcWwt32kT6+uqIeGHJ6+SQ\n\tAgb7DO6+hw+PyPQdgbo7erZ4hh1agqGfCq+z4ABc=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v3 49/50] libcamera: pipeline: Set vblank on more\n\tplatforms", "Date": "Mon, 3 Aug 2026 15:14:34 +0200", "Message-ID": "<20260803131435.153927-50-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "References": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The common `AgcAlgorithm` provides the desired vblank value the given\nframe, so adjust `agc::prepareControls()` accordingly, and propagate\nthe vblank value to the sensors in the pipeline handlers.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 5 +-\n src/ipa/libipa/agc.h | 48 +++++++++++---------\n src/ipa/mali-c55/mali-c55.cpp | 2 +-\n src/ipa/rkisp1/rkisp1.cpp | 3 +-\n src/ipa/simple/soft_simple.cpp | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 1 +\n src/libcamera/pipeline/simple/simple.cpp | 1 +\n 8 files changed, 34 insertions(+), 29 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 0935050a33..7db7270480 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -551,10 +551,7 @@ void IPAIPU3::setControls(unsigned int frame)\n \tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n \n \tControlList ctrls(context_.sensorControls);\n-\tagc::prepareControls(\n-\t\tctrls, context_.camHelper.get(),\n-\t\tframeContext.agc.exposure, frameContext.agc.gain\n-\t);\n+\tagc::prepareControls(ctrls, context_.camHelper.get(), frameContext.agc);\n \n \tControlList lensCtrls(lensCtrls_);\n \tlensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE,\ndiff --git a/src/ipa/libipa/agc.h b/src/ipa/libipa/agc.h\nindex 4f8038ae41..97153541fc 100644\n--- a/src/ipa/libipa/agc.h\n+++ b/src/ipa/libipa/agc.h\n@@ -29,27 +29,6 @@ namespace ipa {\n \n namespace agc {\n \n-[[nodiscard]]\n-inline std::pair<uint32_t, double>\n-extractControls(const ControlList &controls, const CameraSensorHelper *sensor)\n-{\n-\tauto exposure = controls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n-\tauto gainCode = controls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>();\n-\n-\treturn {\n-\t\tuint32_t(exposure),\n-\t\tsensor ? sensor->gain(gainCode) : gainCode,\n-\t};\n-}\n-\n-inline void\n-prepareControls(ControlList &controls, const CameraSensorHelper *sensor,\n-\t\tint32_t exposure, double gain)\n-{\n-\tcontrols.set(V4L2_CID_EXPOSURE, exposure);\n-\tcontrols.set(V4L2_CID_ANALOGUE_GAIN, int32_t(sensor ? sensor->gainCode(gain) : gain));\n-}\n-\n struct Session {\n \tutils::Duration minExposureTime;\n \tutils::Duration maxExposureTime;\n@@ -108,6 +87,33 @@ struct FrameContext {\n \tbool autoGainModeChange;\n };\n \n+\n+[[nodiscard]]\n+inline std::pair<uint32_t, double>\n+extractControls(const ControlList &controls, const CameraSensorHelper *sensor)\n+{\n+\tauto exposure = controls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n+\tauto gainCode = controls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>();\n+\n+\treturn {\n+\t\tuint32_t(exposure),\n+\t\tsensor ? sensor->gain(gainCode) : gainCode,\n+\t};\n+}\n+\n+inline void\n+prepareControls(ControlList &controls, const CameraSensorHelper *sensor,\n+\t\tconst FrameContext &frameContext)\n+{\n+\tuint32_t gain = sensor\n+\t\t? sensor->gainCode(frameContext.gain)\n+\t\t: uint32_t(frameContext.gain);\n+\n+\tcontrols.set(V4L2_CID_EXPOSURE, int32_t(frameContext.exposure));\n+\tcontrols.set(V4L2_CID_ANALOGUE_GAIN, int32_t(gain));\n+\tcontrols.set(V4L2_CID_VBLANK, int32_t(frameContext.vblank));\n+}\n+\n } /* namespace agc */\n \n class AgcAlgorithm\ndiff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp\nindex c0c2c83dca..160f7ac88a 100644\n--- a/src/ipa/mali-c55/mali-c55.cpp\n+++ b/src/ipa/mali-c55/mali-c55.cpp\n@@ -133,7 +133,7 @@ int IPAMaliC55::init(const IPASettings &settings, const IPAConfigInfo &ipaConfig\n void IPAMaliC55::setControls(const IPAFrameContext &frameContext)\n {\n \tControlList ctrls(context_.sensorControls);\n-\tagc::prepareControls(ctrls, context_.camHelper.get(), frameContext.agc.exposure, frameContext.agc.gain);\n+\tagc::prepareControls(ctrls, context_.camHelper.get(), frameContext.agc);\n \n \tsetSensorControls.emit(ctrls);\n }\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 6425d8f1e8..033e69f9f0 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -367,8 +367,7 @@ void IPARkISP1::setControls(unsigned int frame)\n \t\t<< \", gain \" << frameContext.agc.gain << \", vblank \" << vblank;\n \n \tControlList ctrls(context_.sensorControls);\n-\tagc::prepareControls(ctrls, context_.camHelper.get(), exposure, frameContext.agc.gain);\n-\tctrls.set(V4L2_CID_VBLANK, static_cast<int32_t>(vblank));\n+\tagc::prepareControls(ctrls, context_.camHelper.get(), frameContext.agc);\n \n \tsetSensorControls.emit(frame, ctrls);\n }\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex f35e269deb..5d1e0deb87 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -249,7 +249,7 @@ void IPASoftSimple::processStats(const uint32_t frame,\n \tmetadataReady.emit(frame, metadata);\n \n \tControlList ctrls(context_.sensorControls);\n-\tagc::prepareControls(ctrls, context_.camHelper.get(), frameContext.agc.exposure, frameContext.agc.gain);\n+\tagc::prepareControls(ctrls, context_.camHelper.get(), frameContext.agc);\n \tsetSensorControls.emit(ctrls);\n }\n \ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 0f3e169d3b..4147f9475a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1084,6 +1084,7 @@ int PipelineHandlerIPU3::registerCameras()\n \t\tstd::unordered_map<uint32_t, DelayedControls::ControlParams> params = {\n \t\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n \t\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n+\t\t\t{ V4L2_CID_VBLANK, { delays.vblankDelay, true } },\n \t\t};\n \n \t\tdata->delayedCtrls_ =\ndiff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 599ff88b59..ef156d421b 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1909,6 +1909,7 @@ bool PipelineHandlerMaliC55::registerMemoryInputCamera(MediaLink *link)\n \tstd::unordered_map<uint32_t, DelayedControls::ControlParams> params = {\n \t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n \t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n+\t\t{ V4L2_CID_VBLANK, { delays.vblankDelay, true } },\n \t};\n \n \tdata->delayedCtrls_ =\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 3917aa897e..968aab6740 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -569,6 +569,7 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n \tstd::unordered_map<uint32_t, DelayedControls::ControlParams> params = {\n \t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n \t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n+\t\t{ V4L2_CID_VBLANK, { delays.vblankDelay, true } },\n \t};\n \tdelayedCtrls_ = std::make_unique<DelayedControls>(sensor_->device(), params);\n \n", "prefixes": [ "RFC", "v3", "49/50" ] }