Patch Detail
Show a patch.
GET /api/patches/27594/?format=api
{ "id": 27594, "url": "https://patchwork.libcamera.org/api/patches/27594/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27594/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260803131435.153927-48-barnabas.pocze@ideasonboard.com>", "date": "2026-08-03T13:14:32", "name": "[RFC,v3,47/50] ipa: libipa: agc: Take parameters from active state for calculation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3667d08f9ed61b9a9241a5ad964eaed8e94bb4b9", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27594/mbox/", "series": [ { "id": 6103, "url": "https://patchwork.libcamera.org/api/series/6103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6103", "date": "2026-08-03T13:13:45", "name": "ipa: libipa: agc rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27594/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27594/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B98B9C334D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2026 13:15:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 167CE680FB;\n\tMon, 3 Aug 2026 15:15:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AD11680B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:14:49 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79AF0512\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:13:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PXDznkks\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762820;\n\tbh=oON34GAosbFdFIswtIKfVIKOx9fKKj1IlHX+JRinKf4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=PXDznkksI+4G3CVFMGF61YkGcVkQb/MlobUTUZ5YPEky8oMp4nrNq7a5K0/o76P4E\n\tptBWLaj6bNo1vWjDN15Ve7vx3q15MdUy48P2slVv0xyzDNdwfuCMmUZzwPx90nirwb\n\tTq/j6n4P9f5uUsnUloYTEBj1rbeooOVFeIDvbrJA=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v3 47/50] ipa: libipa: agc: Take parameters from active\n\tstate for calculation", "Date": "Mon, 3 Aug 2026 15:14:32 +0200", "Message-ID": "<20260803131435.153927-48-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "References": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The `frameContext` is of an already completed frame, its exposure/gain/etc\nis of no real concern for future frames, so take the most recent settings\nfrom the active state.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/libipa/agc.cpp | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex b8b4cc9e83..bb6891cf51 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -621,22 +621,22 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state,\n \t\tdouble minAnalogueGain;\n \t\tdouble maxAnalogueGain;\n \n-\t\tif (frameContext.autoExposureEnabled) {\n+\t\tif (state.autoExposureEnabled) {\n \t\t\tminExposureTime = session.minExposureTime;\n-\t\t\tmaxExposureTime = std::clamp(frameContext.maxFrameDuration,\n+\t\t\tmaxExposureTime = std::clamp(state.maxFrameDuration,\n \t\t\t\t\t\t session.minExposureTime,\n \t\t\t\t\t\t session.maxExposureTime);\n \t\t} else {\n-\t\t\tminExposureTime = lineDuration * frameContext.exposure;\n+\t\t\tminExposureTime = lineDuration * state.manual.exposure;\n \t\t\tmaxExposureTime = minExposureTime;\n \t\t}\n \n-\t\tif (frameContext.autoGainEnabled) {\n+\t\tif (state.autoGainEnabled) {\n \t\t\tminAnalogueGain = session.minAnalogueGain;\n \t\t\tmaxAnalogueGain = session.maxAnalogueGain;\n \t\t} else {\n-\t\t\tminAnalogueGain = frameContext.gain;\n-\t\t\tmaxAnalogueGain = frameContext.gain;\n+\t\t\tminAnalogueGain = state.manual.gain;\n+\t\t\tmaxAnalogueGain = state.manual.gain;\n \t\t}\n \n \t\tstd::visit(utils::overloaded{\n@@ -681,10 +681,10 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state,\n \t\t\t\t\t.traits = params->traits,\n \t\t\t\t\t.yHist = params->yHist,\n \t\t\t\t\t.effectiveExposureValue = effectiveExposureValue,\n-\t\t\t\t\t.constraintModeIndex = frameContext.constraintMode,\n-\t\t\t\t\t.exposureModeIndex = frameContext.exposureMode,\n+\t\t\t\t\t.constraintModeIndex = state.constraintMode,\n+\t\t\t\t\t.exposureModeIndex = state.exposureMode,\n \t\t\t\t\t.lux = params->lux,\n-\t\t\t\t\t.exposureCompensation = pow(2.0, frameContext.exposureValue),\n+\t\t\t\t\t.exposureCompensation = pow(2.0, state.exposureValue),\n \t\t\t\t});\n \n \t\t\t\t/* Update the estimated exposure and gain. */\n", "prefixes": [ "RFC", "v3", "47/50" ] }