Patch Detail
Show a patch.
GET /api/patches/27588/?format=api
{ "id": 27588, "url": "https://patchwork.libcamera.org/api/patches/27588/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27588/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260803131435.153927-40-barnabas.pocze@ideasonboard.com>", "date": "2026-08-03T13:14:24", "name": "[RFC,v3,39/50] ipa: simple: agc: Use `Histogram`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "57f2c85f08f488e67c51e70636f0fae74bf384f1", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27588/mbox/", "series": [ { "id": 6103, "url": "https://patchwork.libcamera.org/api/series/6103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6103", "date": "2026-08-03T13:13:45", "name": "ipa: libipa: agc rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27588/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27588/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2D99C3347\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2026 13:15:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A63D5680F6;\n\tMon, 3 Aug 2026 15:15:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACA676807D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:14:47 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC432512\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:13:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K9cG57rH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762818;\n\tbh=E985DDPrSQTUb2R+O+XZ6N1q8b6Z6AIwpAePZa0yVVk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=K9cG57rHoeaQ5sy75Mpvlf78Vxg8YW9z/wuNneO4somMsE7RXjqm9UwTlBMNu5rQJ\n\tPt2acPt5Q1qXfG2XE2O17lUpJOQN6KyccB5zjehAjMZ85fPEUis1fABZJTkBfjfzyr\n\td8xkJA+fN1qiWHiI7sgD7G9AoNzKUbblZf+nFG5Q=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v3 39/50] ipa: simple: agc: Use `Histogram`", "Date": "Mon, 3 Aug 2026 15:14:24 +0200", "Message-ID": "<20260803131435.153927-40-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "References": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the generic `Histogram` type. This is needed to decouple the\nimplementation from the software isp, in order to make this usable\nby other components.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/simple/algorithms/agc.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex b25c303835..cc33b269bf 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -14,6 +14,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include <libipa/histogram.h>\n+\n #include \"control_ids.h\"\n \n namespace libcamera {\n@@ -64,16 +66,16 @@ static constexpr float kExpMaxStep = 0.15;\n \n namespace {\n \n-std::optional<float> calculateMSV(const SwIspStats::Histogram &histogram, uint8_t blackLevel)\n+std::optional<float> calculateMSV(const Histogram &histogram, uint8_t blackLevel)\n {\n \t/*\n \t * Calculate Mean Sample Value (MSV) according to formula from:\n \t * https://www.araa.asn.au/acra/acra2007/papers/paper84final.pdf\n \t */\n \tconst unsigned int blackLevelHistIdx =\n-\t\tblackLevel / (256 / SwIspStats::kYHistogramSize);\n+\t\tblackLevel * histogram.bins() / 256;\n \tconst unsigned int histogramSize =\n-\t\tSwIspStats::kYHistogramSize - blackLevelHistIdx;\n+\t\thistogram.bins() - blackLevelHistIdx;\n \tconst unsigned int yHistValsPerBin = histogramSize / kExposureBinsCount;\n \tconst unsigned int yHistValsPerBinMod =\n \t\thistogramSize / (histogramSize % kExposureBinsCount + 1);\n@@ -191,7 +193,7 @@ void Agc::process(IPAContext &context,\n \t\treturn;\n \t}\n \n-\tauto exposureMSV = calculateMSV(stats->yHistogram, context.activeState.blc.level);\n+\tauto exposureMSV = calculateMSV({ stats->yHistogram }, context.activeState.blc.level);\n \tif (!exposureMSV) {\n \t\tLOG(IPASoftExposure, Debug)\n \t\t\t<< \"Not adjusting exposure due to insufficient histogram data\";\n", "prefixes": [ "RFC", "v3", "39/50" ] }